src: add uv_thread_set/getname() methods #4599
Conversation
|
Unfortunately, I couldn't find a better common denominator hence the API differences. Suggestions to improve it are welcome. |
santigimeno
force-pushed
the
santi/thread_set_name
branch
2 times, most recently
from
01e6156 to
763c272
Compare
santigimeno
force-pushed
the
santi/thread_set_name
branch
from
484a9ff to
f5a2c08
Compare
|
I think this is ready now. PTAL. Thanks |
santigimeno
force-pushed
the
santi/thread_set_name
branch
from
f5a2c08 to
28b8f35
Compare
|
I think I have addressed all the comments plus a fix on Windows (I forgot a call to |
santigimeno
force-pushed
the
santi/thread_set_name
branch
from
36c1a16 to
1111453
Compare
|
This fails to link on AIX/IBM i: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/2296/ It's not immediately obvious to me why -- |
Those are ILE APIs which is a different environment from where libuv runs (PASE). There's no such functions in AIX and consequently no such functions in PASE. There is an open idea to provide a wrapper in PASE for the ILE APIs since it's not really possible to convert from a PASE For now, these will have to be ifdef'd on AIX and IBM i to return |
What's the macro to check for IBM i: |
santigimeno
force-pushed
the
santi/thread_set_name
branch
from
1111453 to
3a496a1
Compare
IBM i is FWIW |
As Richard said, IBM i is |
`uv_thread_setname()` sets the name of the current thread. Different platforms define different limits on the max number of characters a thread name can be: Linux, IBMi (16), macOS (64), Windows (32767), and NetBSD (32), etc. `uv_thread_setname()` will truncate it in case `name` is larger than the limit of the platform. `uv_thread_getname()` gets the name of the thread specified by `tid`. The thread name is copied into the buffer pointed to by `name`. The `size` parameter specifies the size of the buffer pointed to by `name`. The buffer should be large enough to hold the name of the thread plus the trailing NUL, or it will be truncated to fit.
santigimeno
force-pushed
the
santi/thread_set_name
branch
from
8703039 to
37bb3c2
Compare
|
Landing this. The qemu failures are due to the Install QEMU step failing but previous builds before squashing were green. Also the failures in https://ci.nodejs.org/view/libuv/job/libuv-test-commit/2298/ are unrelated. Thanks everyone for the reviews. |
Needs libuv/libuv#4599 to land first.
Needs libuv/libuv#4599 to land first.
Needs libuv/libuv#4599 to land first.
uv_thread_getname is not available on aix and ibm i Same issue as thread_name test see: libuv#4599 (comment)
uv_thread_getname is not available on aix and ibm i Same issue as thread_name test Refs: #4599 (comment)
uv_thread_setname()sets the name of the current thread. Differentplatforms define different limits on the max number of characters
a thread name can be: Linux, IBMi (16), macOS (64), Windows (32767),
and NetBSD (32), etc.
uv_thread_setname()will truncate it in casenameis larger than the limit of the platform.uv_thread_getname()gets the name of the thread specified bytid.The thread name is copied into the buffer pointed to by
name. Thesizeparameter specifies the size of the buffer pointed to byname.The buffer should be large enough to hold the name of the thread plus
the trailing NUL, or it will be truncated to fit.