Fix compilation against Windows 24H2 SDK#4576
Merged
vtjnash merged 1 commit intolibuv:v1.xfrom Oct 17, 2024
Merged
Conversation
saghul
approved these changes
Oct 12, 2024
Member
|
Is the new SDK available in GH actions so we can add it to the CI? |
Contributor
Author
|
Not yet, but I assume in the next image update it will get automatically installed, which would then cause this break. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compilation against the 24H2 SDK is broken by #4327
Fix that issue by only conditionally defining the new values.
Closes #4575