process: only use F_DUPFD_CLOEXEC if it is defined#3512
Merged
vtjnash merged 1 commit intolibuv:v1.xfrom Mar 5, 2022
Merged
Conversation
We can save a syscall on most modern systems (required by POSIX 2008), but not on all systems. Also handle errors from CLOEXEC. Even though fcntl does not really define there to be any, it could theoretically be EBADF if the user happened to pass a bad file descriptor to the same number fd (such that no other code happened to already fail on that).
vtjnash
force-pushed
the
jn/F_DUPFD_CLOEXEC
branch
from
32837a9 to
2b4c6e6
Compare
bnoordhuis
approved these changes
Mar 5, 2022
richardlau
approved these changes
Mar 5, 2022
santigimeno
approved these changes
Mar 5, 2022
This was referenced Mar 18, 2022
JeffroMF
pushed a commit
to JeffroMF/libuv
that referenced
this pull request
May 16, 2022
We can save a syscall on most modern systems (required by POSIX 2008), but not on all systems. Also handle errors from CLOEXEC. Even though fcntl does not really define there to be any, it could theoretically be EBADF if the user happened to pass a bad file descriptor to the same number fd (such that no other code happened to already fail on that).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can save a syscall on most modern systems (required by POSIX 2008),
but not on all systems.
Should resolved the complaints in #3257 (comment)
CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/2232/