Skip to content

process,bsd: handle kevent NOTE_EXIT failure#3451

Merged
vtjnash merged 1 commit intolibuv:v1.xfrom
vtjnash:jn/kevent-ESRCH
Feb 1, 2022
Merged

process,bsd: handle kevent NOTE_EXIT failure#3451
vtjnash merged 1 commit intolibuv:v1.xfrom
vtjnash:jn/kevent-ESRCH

Conversation

@vtjnash
Copy link
Copy Markdown
Member

@vtjnash vtjnash commented Feb 1, 2022

The kernel may return ESRCH if the child has already exited here.
This is rather annoying, and means we must indirectly handle
notification to our event loop of the process exit.

Refs: #3441
Refs: #3257

The kernel may return ESRCH if the child has already exited here.
This is rather annoying, and means we must indirectly handle
notification to our event loop of the process exit.

Refs: libuv#3441
Refs: libuv#3257
@vtjnash vtjnash mentioned this pull request Feb 1, 2022
@vtjnash
Copy link
Copy Markdown
Member Author

vtjnash commented Feb 1, 2022

Copy link
Copy Markdown
Contributor

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me! Thanks for the fix :)

@vtjnash vtjnash merged commit 953f901 into libuv:v1.x Feb 1, 2022
@vtjnash vtjnash deleted the jn/kevent-ESRCH branch February 1, 2022 20:27
JeffroMF pushed a commit to JeffroMF/libuv that referenced this pull request May 16, 2022
The kernel may return ESRCH if the child has already exited here.
This is rather annoying, and means we must indirectly handle
notification to our event loop of the process exit.

Refs: libuv#3441
Refs: libuv#3257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants