win: fix uv_fs_access on directories #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Contributor
|
Definitely an improvement - LGTM. My general beef with the current API is that it doesn't "check" whether the file is actually writable (which is controlled by the ACL and not the arcane readonly flag). A strategy may also be to just try and open the file for writing - although that would also incorrectly locked files as unaccessible. |
For posterity, these are the rules for access on Windows (taken from CPython's implementation), Access is possible if: * Write access wasn't requested * The file isn't read-only * It's a directory (directories cannot be read-only on Windows) PR-URL: libuv#316 Reviewed-By: Bert Belder <[email protected]>
Member
Author
|
Thanks Bert, landed. I'm all in for improving it further, can you point me to those ACL related APIs? Do we already use them similarly anywhere in the code? FWIW, I wouldn't want to try and open the file, the user could just use uv_fs_open in that case, I see uv_fs_access as a LBYL style API, which of course could fail between the user checking, and the user acting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For posterity, these are the rules for access on Windows (taken from
CPython's implementation), Access is possible if:
R=@piscisaureus
/cc @cjihrig
Should fix: nodejs/node#1397