unix,win: add uv_random() #2347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santigimeno
approved these changes
Jun 23, 2019
bnoordhuis
commented
Jun 24, 2019
saghul
reviewed
Jun 25, 2019
Member
saghul
left a comment
saghul
left a comment
There was a problem hiding this comment.
Left some comments and a question, thanks for picking this up Ben!
bnoordhuis
commented
Jun 27, 2019
saghul
reviewed
Jun 28, 2019
Contributor
|
@bnoordhuis the CI link is expired. Just double checking - from reading the comments, it looks like this isn't ready. Is that correct? If it's not, do you want to try to get this in the next release? I'm mainly asking for selfish personal reasons. |
Member
Author
|
Hah, I figured you'd be interested in that. :-) I'm afraid it still needs more work. It's on my todo list but it's a pretty busy time for me right now. |
Member
|
Ping, I grew some interest too :-) Any way I can help? |
Member
Author
|
@saghul If you want to pick this up that'd be great. You should be able to push to my branch, and if not, let me know and I'll give you commit rights to my fork. |
saghul
force-pushed
the
uv_random
branch
2 times, most recently
from
2fd425c to
3879f12
Compare
Member
|
Pushed a fixup. CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1575/ Still TODO: handle the AIX / IBMi comment. |
Member
|
Updated with the suggested IBMi and AIX fixes: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1576/ PTAL @bnoordhuis |
Member
|
There seem to be legit failures on windows. Will dig. |
Member
Contributor
|
The CI is having all sorts of issues right now, but none of the failures look related 👍 |
bnoordhuis
commented
Sep 16, 2019
Member
Author
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
I can't LGTM my own PR but... LGTM ^^
Nice to see this come to completion. Great job, Saúl.
Member
|
@bnoordhuis I fixed the couple of nits, squashed, rebased and approved ;-) Please take one last look. |
cjihrig
approved these changes
Sep 17, 2019
bnoordhuis
commented
Sep 17, 2019
docs/src/misc.rst
Outdated
| - macOS, OpenBSD: `getentropy(2) <https://man.openbsd.org/getentropy.2>_` | ||
| if available, or `/dev/urandom` after reading from `/dev/random` once. | ||
| - AIX: `/dev/random`. | ||
| - IBMi: `/dev/urandom`. |
Member
Author
There was a problem hiding this comment.
Suggested change
| - IBMi: `/dev/urandom`. | |
| - IBM i: `/dev/urandom`. |
Add an API for obtaining cryptographically strong random data from the system PRNG. Co-authored-by: Saúl Ibarra Corretgé <[email protected]> Refs: libuv#1055 PR-URL: libuv#2347 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Member
|
Landed in ✨ 4ed2a78 ✨ |
vtjnash
added a commit
to vtjnash/libuv
that referenced
this pull request
Jan 7, 2020
Introduced in libuv#2404 and libuv#2347.
Closed
cjihrig
pushed a commit
that referenced
this pull request
Jan 8, 2020
Introduced in #2404 and #2347. PR-URL: #2609 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 13, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 13, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 13, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 13, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 13, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 13, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 15, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 18, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 21, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 21, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 24, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 24, 2020
* chore: bump node in DEPS to v12.16.0 * Fixup asar support setup patch nodejs/node#30862 * Fixup InternalCallbackScope patch nodejs/node#30236 * Fixup GN buildfiles patch nodejs/node#30755 * Fixup low-level hooks patch nodejs/node#30466 * Fixup globals require patch nodejs/node#31643 * Fixup process stream patch nodejs/node#30862 * Fixup js2c modification patch nodejs/node#30755 * Fixup internal fs override patch nodejs/node#30610 * Fixup context-aware warn patch nodejs/node#30336 * Fixup Node.js with ltcg config nodejs/node#29388 * Fixup oaepLabel patch nodejs/node#30917 * Remove redundant ESM test patch nodejs/node#30997 * Remove redundant cli flag patch nodejs/node#30466 * Update filenames.json * Remove macro generation in GN build files nodejs/node#30755 * Fix some compilation errors upstream * Add uvwasi to deps nodejs/node#30258 * Fix BoringSSL incompatibilities * Fixup linked module patch nodejs/node#30274 * Add missing sources to GN uv build libuv/libuv#2347 * Patch some uvwasi incompatibilities * chore: bump Node.js to v12.6.1 * Remove mark_arraybuffer_as_untransferable.patch nodejs/node#30549 * Fix uvwasi build failure on win * Fixup --perf-prof cli option error * Fixup early cjs module loading * fix: initialize diagnostics properly nodejs/node#30025 * Disable new esm syntax specs nodejs/node#30219 * Fixup v8 weakref hook spec nodejs/node#29874 * Fix async context timer issue * Disable monkey-patch-main spec It relies on nodejs/node#29777, and we don't override prepareStackTrace. * Disable new tls specs nodejs/node#23188 We don't support much of TLS owing to schisms between BoringSSL and OpenSSL. Co-authored-by: Shelley Vohr <[email protected]>
chjj
added a commit
to bcoin-org/libtorsion
that referenced
this pull request
Oct 26, 2021
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Jul 23, 2025
Add an API for obtaining cryptographically strong random data from the system PRNG. Co-authored-by: Saúl Ibarra Corretgé <[email protected]> Refs: libuv/libuv#1055 PR-URL: libuv/libuv#2347 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Jul 23, 2025
Introduced in libuv/libuv#2404 and libuv/libuv#2347. PR-URL: libuv/libuv#2609 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Dec 16, 2025
Add an API for obtaining cryptographically strong random data from the system PRNG. Co-authored-by: Saúl Ibarra Corretgé <[email protected]> Refs: libuv/libuv#1055 PR-URL: libuv/libuv#2347 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Dec 16, 2025
Introduced in libuv/libuv#2404 and libuv/libuv#2347. PR-URL: libuv/libuv#2609 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an API for obtaining cryptographically strong random data from the
system PRNG.
Refs: #1055
CI: https://ci.nodejs.org/job/libuv-test-commit/1437/ (still need to figure out why random_sync fails on Windows)