linux: read free/total memory from /proc/meminfo #2258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Apr 15, 2019
ptlomholt
reviewed
Apr 16, 2019
Member
Author
|
New CI, the old one expired: https://ci.nodejs.org/job/libuv-test-commit/1371/ |
Member
Author
|
Okay, the clever approach gets defeated by the absence of |
It was reported that uv_get_free_memory() and uv_get_total_memory() report the wrong values inside an lxc container. Libuv calls sysinfo(2) but that isn't intercepted by lxc. /proc/meminfo however is because /proc is a FUSE fs inside the container. This commit makes libuv try /proc/meminfo first and fall back to sysinfo(2) in case /proc isn't mounted. Fixes: libuv#2249 PR-URL: libuv#2258 Reviewed-By: Colin Ihrig <[email protected]>
This was referenced May 1, 2019
Closed
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Jul 23, 2025
It was reported that uv_get_free_memory() and uv_get_total_memory() report the wrong values inside an lxc container. Libuv calls sysinfo(2) but that isn't intercepted by lxc. /proc/meminfo however is because /proc is a FUSE fs inside the container. This commit makes libuv try /proc/meminfo first and fall back to sysinfo(2) in case /proc isn't mounted. Fixes: libuv/libuv#2249 PR-URL: libuv/libuv#2258 Reviewed-By: Colin Ihrig <[email protected]>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Dec 16, 2025
It was reported that uv_get_free_memory() and uv_get_total_memory() report the wrong values inside an lxc container. Libuv calls sysinfo(2) but that isn't intercepted by lxc. /proc/meminfo however is because /proc is a FUSE fs inside the container. This commit makes libuv try /proc/meminfo first and fall back to sysinfo(2) in case /proc isn't mounted. Fixes: libuv/libuv#2249 PR-URL: libuv/libuv#2258 Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported that uv_get_free_memory() and uv_get_total_memory()
report the wrong values inside an lxc container.
Libuv calls sysinfo(2) but that isn't intercepted by lxc. /proc/meminfo
however is because /proc is a FUSE fs inside the container.
This commit makes libuv try /proc/meminfo first and fall back to
sysinfo(2) in case /proc isn't mounted.
Fixes: #2249
The second commit DRYs the code in exchange for what might be considered a little more magic. Majority rule; I don't feel strongly about what approach is better.
CI: https://ci.nodejs.org/job/libuv-test-commit/1364/