win: return product name in uv_os_uname() version #2170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Windows CI: https://ci.nodejs.org/job/libuv-test-commit-windows/1317/ (particularly https://ci.nodejs.org/job/libuv-test-commit-windows/1317/nodes=win2008r2-vs2013/, since none of the other hosts appear to have service packs installed) EDIT: CI was fine. Example output below EDIT: New CI that handles registry issues more gracefully: https://ci.nodejs.org/job/libuv-test-commit-windows/1318/ |
bnoordhuis
reviewed
Feb 5, 2019
cjihrig
force-pushed
the
uname
branch
2 times, most recently
from
b6a6973 to
4b66a69
Compare
refack
reviewed
Feb 5, 2019
refack
reviewed
Feb 5, 2019
cjihrig
force-pushed
the
uname
branch
4 times, most recently
from
c7ebe31 to
a45eff0
Compare
refack
approved these changes
Feb 5, 2019
bzoz
approved these changes
Feb 7, 2019
Currently, on Windows the uv_utsname_t's version field can be an empty string if no service packs are installed. This isn't very helpful, and a lot more information is available in the Windows registry. This commit prepends the full product name to the existing service pack information. Refs: nodejs/node#25843 Refs: libuv#2128 (comment) PR-URL: libuv#2170 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
Contributor
Author
|
Thanks for the reviews! |
2 tasks
cjihrig
added a commit
to cjihrig/node
that referenced
this pull request
Feb 13, 2019
Notable changes: - A bug that could result in 100% CPU utilization in Node has been fixed (libuv/libuv#2162) - Node's report module will now include the entire Windows product name (libuv/libuv#2170) PR-URL: nodejs#26037 Fixes: nodejs#26013 Fixes: nodejs#25875 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
addaleax
pushed a commit
to nodejs/node
that referenced
this pull request
Feb 13, 2019
Notable changes: - A bug that could result in 100% CPU utilization in Node has been fixed (libuv/libuv#2162) - Node's report module will now include the entire Windows product name (libuv/libuv#2170) PR-URL: #26037 Fixes: #26013 Fixes: #25875 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
njlr
pushed a commit
to buckaroo-pm/libuv
that referenced
this pull request
Apr 5, 2019
Currently, on Windows the uv_utsname_t's version field can be an empty string if no service packs are installed. This isn't very helpful, and a lot more information is available in the Windows registry. This commit prepends the full product name to the existing service pack information. Refs: nodejs/node#25843 Refs: libuv#2128 (comment) PR-URL: libuv#2170 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
May 16, 2019
Notable changes: - A bug that could result in 100% CPU utilization in Node has been fixed (libuv/libuv#2162) - Node's report module will now include the entire Windows product name (libuv/libuv#2170) PR-URL: nodejs#26037 Fixes: nodejs#26013 Fixes: nodejs#25875 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
MylesBorins
pushed a commit
to nodejs/node
that referenced
this pull request
May 16, 2019
Notable changes: - A bug that could result in 100% CPU utilization in Node has been fixed (libuv/libuv#2162) - Node's report module will now include the entire Windows product name (libuv/libuv#2170) Backport-PR-URL: #27728 PR-URL: #26037 Fixes: #26013 Fixes: #25875 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Jul 23, 2025
Currently, on Windows the uv_utsname_t's version field can be an empty string if no service packs are installed. This isn't very helpful, and a lot more information is available in the Windows registry. This commit prepends the full product name to the existing service pack information. Refs: nodejs/node#25843 Refs: libuv/libuv#2128 (comment) PR-URL: libuv/libuv#2170 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
liujinye-sys
pushed a commit
to open-vela/apps_system_libuv
that referenced
this pull request
Dec 16, 2025
Currently, on Windows the uv_utsname_t's version field can be an empty string if no service packs are installed. This isn't very helpful, and a lot more information is available in the Windows registry. This commit prepends the full product name to the existing service pack information. Refs: nodejs/node#25843 Refs: libuv/libuv#2128 (comment) PR-URL: libuv/libuv#2170 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, on Windows the
uv_utsname_t'sversionfield can be an empty string if no service packs are installed. This isn't very helpful, and a lot more information is available in the Windows registry. This commit prepends the full product name to the existing service pack information.Refs: nodejs/node#25843
Refs: #2128 (comment)