linux: don't use uv__nonblock_ioctl() on sparc#1832
Merged
bnoordhuis merged 1 commit intolibuv:v1.xfrom May 6, 2018
Merged
Conversation
santigimeno
approved these changes
May 3, 2018
cjihrig
approved these changes
May 3, 2018
uv__nonblock_fcntl() and uv__nonblock_ioctl() do not commute when O_NDELAY is not equal to O_NONBLOCK. Case in point: linux/sparc32 and linux/sparc64, where O_NDELAY is O_NONBLOCK + another bit. Libuv uses uv__nonblock_fcntl() directly sometimes so ensure that it commutes with uv__nonblock(). Fixes: libuv#1830 PR-URL: libuv#1832 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uv__nonblock_fcntl() and uv__nonblock_ioctl() do not commute when
O_NDELAY is not equal to O_NONBLOCK. Case in point: linux/sparc32
and linux/sparc64, where O_NDELAY is O_NONBLOCK + another bit.
Libuv uses uv__nonblock_fcntl() directly sometimes so ensure that it
commutes with uv__nonblock().
Fixes: #1830
CI: https://ci.nodejs.org/job/libuv-test-commit/824/