Skip to content

cfmakeraw() in uv_tty_set_mode() causing downstream issues #32

Closed

Description

@cjihrig

0f25560, specifically related to c_oflag, appears to be the cause of nodejs/node-v0.x-archive#8817.

Linking to the original libuv PR, which has some additional info.

cc: @bnoordhuis

Activity

  1. bnoordhuis commented on Dec 4, 2014

    @bnoordhuis
    Member

    @saghul I suggest reverting 0f25560 for now. Adding ONLCR | OPOST won't help because that renders the TTY unsuitable for binary I/O, which was the reason for switching to cfmakeraw() in the first place.

  2. bnoordhuis commented on Dec 4, 2014

    @bnoordhuis
    Member

    Fixed per commit 484a3a9.

  3. added a commit that references this issue on Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions