Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: libuv/libuv
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 60e515d
Choose a base ref
...
head repository: libuv/libuv
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c619f37
Choose a head ref
  • 7 commits
  • 5 files changed
  • 1 contributor

Commits on Jun 14, 2015

  1. win,stream: add slot to remember CRT fd 

    Certain types of streams may be opened from a CRT file descriptor (as
opposed to a Windows HANDLE). In order to close the file descriptor
later, libuv must store the file descriptor used to open the stream.

PR-URL: #396
Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
    @piscisaureus
    piscisaureus committed Jun 14, 2015
    Configuration menu
    Copy the full SHA
    b6bf6d2 View commit details
    Browse the repository at this point in the history

  2. win,pipe: properly close when created from CRT fd 

    When a Windows handle was opened from a CRT fd, it needs to be closed
with `close()` instead of `CloseHandle()`.

PR-URL: #396
Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
    @piscisaureus
    piscisaureus committed Jun 14, 2015
    Configuration menu
    Copy the full SHA
    4ed29c2 View commit details
    Browse the repository at this point in the history

  3. win,pipe: don't close fd 0-2 

    PR-URL: #396
Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
    @piscisaureus
    piscisaureus committed Jun 14, 2015
    Configuration menu
    Copy the full SHA
    90fb8cb View commit details
    Browse the repository at this point in the history

  4. win,tty: convert fd -> handle safely 

    _get_osfhandle() may throw if it's used to convert a non-open file
descriptor to a Windows HANDLE. Use the safe uv__get_osfhandle instead.

PR-URL: #396
Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
    @piscisaureus
    piscisaureus committed Jun 14, 2015
    Configuration menu
    Copy the full SHA
    0bad50a View commit details
    Browse the repository at this point in the history

  5. win,tty: properly close when created from CRT fd 

    When a Windows handle was opened from a CRT fd, it needs to be closed
with `close()` instead of `CloseHandle()`.

PR-URL: #396
Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
    @piscisaureus
    piscisaureus committed Jun 14, 2015
    Configuration menu
    Copy the full SHA
    164fbda View commit details
    Browse the repository at this point in the history

  6. win,tty: don't close fd 0-2 

    PR-URL: #396
Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
    @piscisaureus
    piscisaureus committed Jun 14, 2015
    Configuration menu
    Copy the full SHA
    f6fc5dd View commit details
    Browse the repository at this point in the history

  7. win,fs: don't close fd 0-2 

    PR-URL: #396
Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
    @piscisaureus
    piscisaureus committed Jun 14, 2015
    Configuration menu
    Copy the full SHA
    c619f37 View commit details
    Browse the repository at this point in the history
Loading