win,fs: remove trailing slash in junctions

huseyinacacak-janea · saghul · commit fbe2d85bd5a5 · 2024-10-15T09:48:27.000+02:00
Fixes: #3329
diff --git a/src/win/fs.c b/src/win/fs.c
@@ -2566,7 +2566,6 @@ static void fs__create_junction(uv_fs_t* req, const WCHAR* path,
 
     path_buf[path_buf_len++] = path[i];
   }
-  path_buf[path_buf_len++] = L'\\';
   len = path_buf_len - start;
 
   /* Set the info about the substitute name */
diff --git a/test/test-fs.c b/test/test-fs.c
@@ -2379,8 +2379,8 @@ int test_symlink_dir_impl(int type) {
   strcpy(test_dir_abs_buf, "\\\\?\\");
   uv_cwd(test_dir_abs_buf + 4, &test_dir_abs_size);
   test_dir_abs_size += 4;
-  strcat(test_dir_abs_buf, "\\test_dir\\");
-  test_dir_abs_size += strlen("\\test_dir\\");
+  strcat(test_dir_abs_buf, "\\test_dir");
+  test_dir_abs_size += strlen("\\test_dir");
   test_dir = test_dir_abs_buf;
 #else
   uv_cwd(test_dir_abs_buf, &test_dir_abs_size);
@@ -2435,8 +2435,8 @@ int test_symlink_dir_impl(int type) {
   r = uv_fs_realpath(NULL, &req, "test_dir_symlink", NULL);
   ASSERT_OK(r);
 #ifdef _WIN32
-  ASSERT_EQ(strlen(req.ptr), test_dir_abs_size - 5);
-  ASSERT_OK(_strnicmp(req.ptr, test_dir + 4, test_dir_abs_size - 5));
+  ASSERT_EQ(strlen(req.ptr), test_dir_abs_size - 4);
+  ASSERT_OK(_strnicmp(req.ptr, test_dir + 4, test_dir_abs_size - 4));
 #else
   ASSERT_OK(strcmp(req.ptr, test_dir_abs_buf));
 #endif

Original file line number	Diff line number	Diff line change
`@@ -2566,7 +2566,6 @@ static void fs__create_junction(uv_fs_t* req, const WCHAR* path,`
`2566`	`2566`
`2567`	`2567`	`path_buf[path_buf_len++] = path[i];`
`2568`	`2568`	`}`
`2569`		`- path_buf[path_buf_len++] = L'\\';`
`2570`	`2569`	`len = path_buf_len - start;`
`2571`	`2570`
`2572`	`2571`	`/* Set the info about the substitute name */`