Fix FTBFS in src/ptrace/_UPT_ptrauth_insn_mask.c#853
Merged
Conversation
Added missing parameter names to make C code comply to ISO/IEC 9899.
Contributor
|
Can this be backported to the 1.8 branch? |
Keno
added a commit
to JuliaLang/julia
that referenced
this pull request
Jun 3, 2025
Apply patch from libunwind/libunwind#853 to add missing parameter names in _UPT_ptrauth_insn_mask function to comply with ISO/IEC 9899. Prior to GCC 11, omitting parameter names in function definitions was an error. GCC 11 changed this behavior in commit https://gcc.gnu.org/pipermail/gcc-cvs/2020-October/336068.html to allow omitted parameter names as a C2x extension, making it a pedantic warning instead of an error. Since we build without -Wpedantic, the code compiles fine with GCC 11+ but fails with older GCC versions. Fixes scheduled CI failures in libunwind build: https://buildkite.com/julialang/julia-master-scheduled/builds/1160
Keno
added a commit
to JuliaLang/julia
that referenced
this pull request
Jun 3, 2025
Apply patch from libunwind/libunwind#853 to add missing parameter names in _UPT_ptrauth_insn_mask function to comply with ISO/IEC 9899. Prior to GCC 11, omitting parameter names in function definitions was an error. GCC 11 changed this behavior in commit https://gcc.gnu.org/pipermail/gcc-cvs/2020-October/336068.html to allow omitted parameter names as a C2x extension, making it a pedantic warning instead of an error. Since we build without -Wpedantic, the code compiles fine with GCC 11+ but fails with older GCC versions. Fixes scheduled CI failures in libunwind build: https://buildkite.com/julialang/julia-master-scheduled/builds/1160
Keno
added a commit
to JuliaLang/julia
that referenced
this pull request
Jun 4, 2025
Apply patch from libunwind/libunwind#853 to add missing parameter names in _UPT_ptrauth_insn_mask function to comply with ISO/IEC 9899. Prior to GCC 11, omitting parameter names in function definitions was an error. GCC 11 changed this behavior in commit https://gcc.gnu.org/pipermail/gcc-cvs/2020-October/336068.html to allow omitted parameter names as a C2x extension, making it a pedantic warning instead of an error. Since we build without -Wpedantic, the code compiles fine with GCC 11+ but fails with older GCC versions. Fixes scheduled CI failures in libunwind build: https://buildkite.com/julialang/julia-master-scheduled/builds/1160
Keno
added a commit
to JuliaLang/julia
that referenced
this pull request
Jun 4, 2025
Apply patch from libunwind/libunwind#853 to add missing parameter names in _UPT_ptrauth_insn_mask function to comply with ISO/IEC 9899. Prior to GCC 11, omitting parameter names in function definitions was an error. GCC 11 changed this behavior in commit https://gcc.gnu.org/pipermail/gcc-cvs/2020-October/336068.html to allow omitted parameter names as a C2x extension, making it a pedantic warning instead of an error. Since we build without -Wpedantic, the code compiles fine with GCC 11+ but fails with older GCC versions. Fixes scheduled CI failures in libunwind build: https://buildkite.com/julialang/julia-master-scheduled/builds/1160
Keno
added a commit
to JuliaLang/julia
that referenced
this pull request
Jun 5, 2025
Apply patch from libunwind/libunwind#853 to add missing parameter names in _UPT_ptrauth_insn_mask function to comply with ISO/IEC 9899. Prior to GCC 11, omitting parameter names in function definitions was an error. GCC 11 changed this behavior in commit https://gcc.gnu.org/pipermail/gcc-cvs/2020-October/336068.html to allow omitted parameter names as a C2x extension, making it a pedantic warning instead of an error. Since we build without -Wpedantic, the code compiles fine with GCC 11+ but fails with older GCC versions. Fixes scheduled CI failures in libunwind build: https://buildkite.com/julialang/julia-master-scheduled/builds/1160
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missing parameter names to make C code comply to ISO/IEC 9899.
Fixes #852