Skip to content

Expose get_proc_info_in_range API #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bregma merged 1 commit into from
Jul 8, 2022
Merged

Expose get_proc_info_in_range API #377

bregma merged 1 commit into from
Jul 8, 2022

Conversation

@am11
Copy link
Contributor

@am11 am11 commented Jun 29, 2022

@am11 am11 force-pushed the feature/get_proc_info_in_range branch from c778abb to 3801ab7 Compare June 29, 2022 16:13
@am11
Copy link
Contributor Author

am11 commented Jun 29, 2022

cc @mikem8361, @AaronRobinsonMSFT, @janvorli. PTAL.

This is upstreaming https://github.com/dotnet/runtime/tree/2a38e20/src/native/external/libunwind_extras/oop, adapting to the format from PR #299.

The .man file is autogenerated based on .tex LaTeX file. The Description section can use more/better text. @mikem8361 if you could provide additional description for this document, that would be great.

AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Jun 29, 2022
View reviewed changes
src/mi/Lget_proc_info_in_range.c
@@ -0,0 +1,5 @@
#define UNW_LOCAL_ONLY
Copy link
Contributor

@AaronRobinsonMSFT AaronRobinsonMSFT Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License?

Copy link
Contributor Author

@am11 am11 Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The local (L) source just include the global (G) ones with guard where I added the header. None of the other L files have the license: cat src/mi/L*.

@am11 am11 mentioned this pull request Jun 29, 2022
Open
@am11 am11 force-pushed the feature/get_proc_info_in_range branch from 1225f9a to 88988ef Compare June 29, 2022 21:15
@am11 am11 mentioned this pull request Jun 29, 2022
Merged
@am11
Copy link
Contributor Author

am11 commented Jul 8, 2022

@bregma, PTAL. CI failures are unrelated to the change.

@bregma
Copy link
Member

bregma commented Jul 8, 2022

Agreed. No new regressions introduced. LGTM.

@bregma bregma merged commit 4640cd2 into libunwind:master Jul 8, 2022
@bregma bregma mentioned this pull request Jan 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT left review comments

@mikem8361 mikem8361 mikem8361 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@am11 @bregma @mikem8361 @AaronRobinsonMSFT