Fix placement of alignas() specifier#186
Merged
djwatson merged 2 commits intolibunwind:masterfrom Jun 18, 2020
Merged
Conversation
The alignment specifier must appear before the typename i.e. clang9 refused to compile uint8_t alignas(MAX_ALIGN) __reserved[128]; but accepted alignas(MAX_ALIGN) uint8_t __reserved[128];
sdmaclea
added a commit
to sdmaclea/runtime
that referenced
this pull request
Jun 11, 2020
sdmaclea
added a commit
to dotnet/runtime
that referenced
this pull request
Jun 18, 2020
* Libunwind v1.5-rc1-28-g9165d2a1 Pull upstream libunwind which supports building on Windows * Alignas and typos libunwind/libunwind#186 * Update libunwind-version.txt * Add libunwind to cross DAC * Colocate Unix/Windows compiler config * Unify Windows/Unix configure.cmake
Member
|
merged, thanks. |
sdmaclea
added a commit
to sdmaclea/coreclr
that referenced
this pull request
Jun 25, 2020
Libunwind 1.5rc2 again (dotnet/runtime#36988) * Add arm64 support for UNWIND_CONTEXT_IS_UCONTEXT_T==0 * Reapply libunwind 1.5rc2 * Fix Linux Alpine libunwind1.5rc2 Add libunwind to cross DAC (dotnet/runtime#37521) * Libunwind v1.5-rc1-28-g9165d2a1 Pull upstream libunwind which supports building on Windows * Alignas and typos libunwind/libunwind#186 * Update libunwind-version.txt * Add libunwind to cross DAC * Colocate Unix/Windows compiler config * Unify Windows/Unix configure.cmake
sdmaclea
added a commit
to sdmaclea/coreclr
that referenced
this pull request
Jun 25, 2020
Libunwind 1.5rc2 again (dotnet/runtime#36988) * Add arm64 support for UNWIND_CONTEXT_IS_UCONTEXT_T==0 * Reapply libunwind 1.5rc2 * Fix Linux Alpine libunwind1.5rc2 Add libunwind to cross DAC (dotnet/runtime#37521) * Libunwind v1.5-rc1-28-g9165d2a1 Pull upstream libunwind which supports building on Windows * Alignas and typos libunwind/libunwind#186 * Update libunwind-version.txt * Add libunwind to cross DAC * Colocate Unix/Windows compiler config * Unify Windows/Unix configure.cmake
|
It seems it broke C++98 code, e.g. roc-toolkit (roc-streaming/roc-toolkit#481). Is libunwind C++11 only? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alignment specifier must appear before the typename
i.e. clang9 refuses to compile
uint8_t alignas(MAX_ALIGN) __reserved[128];
but accepts
alignas(MAX_ALIGN) uint8_t __reserved[128];