Skip to content

Fix uninitialized memory in TCODPath and TCODDijkstra#160

Merged
HexDecimal merged 3 commits intomainfrom
fix-159
Mar 19, 2025
Merged

Fix uninitialized memory in TCODPath and TCODDijkstra#160
HexDecimal merged 3 commits intomainfrom
fix-159

Conversation

@HexDecimal
Copy link
Collaborator

@HexDecimal HexDecimal commented Mar 19, 2025

Initialize memory by default so that swap operations are valid, used by move

Test move for TCODPath

Fixes #159

Also updated similar classes with uninitialized memory.

Initialize memory by default so that swap operations are valid, used by move

Test move for TCODPath

Fixes #159
@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 25.44%. Comparing base (996587f) to head (9aa475a).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/libtcod/path.cpp 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
+ Coverage   24.93%   25.44%   +0.51%     
==========================================
  Files         109      110       +1     
  Lines       12690    12700      +10     
  Branches     2052     2054       +2     
==========================================
+ Hits         3164     3232      +68     
+ Misses       9526     9468      -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HexDecimal HexDecimal merged commit 22412e5 into main Mar 19, 2025
27 checks passed
@HexDecimal HexDecimal deleted the fix-159 branch March 19, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double free after move for TCODPath

1 participant