Remove OpenGL renderers and SDL software fallback renderer.#137
Merged
HexDecimal merged 1 commit intomainfrom Nov 7, 2022
Merged
Remove OpenGL renderers and SDL software fallback renderer.#137HexDecimal merged 1 commit intomainfrom
HexDecimal merged 1 commit intomainfrom
Conversation
HexDecimal
force-pushed
the
remove-renderers
branch
from
d702cb3 to
3f2811e
Compare
Codecov Report
@@ Coverage Diff @@
## main #137 +/- ##
==========================================
+ Coverage 19.35% 20.26% +0.90%
==========================================
Files 127 123 -4
Lines 13595 12986 -609
==========================================
Hits 2631 2631
+ Misses 10964 10355 -609
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removes references to GLAD, since that is no longer used.
These renderers have graphical artifacts on specific hardware. I do not have the resources to fix these issues directly, but the SDL2 renderer has progressed enough for me to reconsider if they're even necessary. Fixes #112, Fixes #83.
This will also help with #18 as there's less I need to work with.
Note that the graphics issues were mainly with the OpenGL2 renderer, the OpenGL1 render was working fine, however, the SDL2 renderer now matches it in performance, leaving not much reason to keep it around.
This closes the non-working PR's #113, #114.