Skip to content

Fix OpenGL2 renderer artifacts.#113

Closed
HexDecimal wants to merge 6 commits intomainfrom
update-glsl
Closed

Fix OpenGL2 renderer artifacts.#113
HexDecimal wants to merge 6 commits intomainfrom
update-glsl

Conversation

@HexDecimal
Copy link
Collaborator

I'm trying to fix the artifacts found in #83 and #112 but since I don't have the hardware/drivers which trigger the artifacts I will not be able to test if these changes fix anything. I'll need someone to verify the fixes.

This PR is trying to find the minimal changes need to fix the shader. I've also made changes to make sure that the shaders in the .glslv/.glslf files are in sync with the C sources.

Closes #112 Closes #83

@codecov
Copy link

codecov bot commented Mar 26, 2022

Codecov Report

Merging #113 (dc9536b) into main (f9c2d9d) will not change coverage.
The diff coverage is 0.00%.

❗ Current head dc9536b differs from pull request most recent head a0409a2. Consider uploading reports for the commit a0409a2 to get more accurate results

@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   12.47%   12.47%           
=======================================
  Files         125      125           
  Lines       13326    13326           
=======================================
  Hits         1663     1663           
  Misses      11663    11663           
Impacted Files Coverage Δ
src/libtcod/renderer_gl2.c 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@HexDecimal HexDecimal changed the base branch from develop to main August 11, 2022 11:26
This tileset has fewer issues with the edges of some glyphs.
Should workaround issues where drivers used other LOD levels in
textures which don't have LOD.
This should avoid issues with GLES2 which doesn't have texture2DLod.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Artifacts/garbage with OPENGL2 renderer in Windows Text alignment doesn't seem to work after updating?

1 participant