libssh2.pc: re-add & extend support for static-only libssh2 builds#1119
libssh2.pc: re-add & extend support for static-only libssh2 builds#1119vszakats wants to merge 6 commits intolibssh2:masterfrom
Conversation
|
Misc observations comparing
Ref:
|
vszakats
changed the title
Libs: for static buildsLibs: for static-only builds
vszakats
changed the title
Libs: for static-only buildsLibs: for static-only builds
Quoting the curl commit message (adapted for libssh2): "A project being built entirely statically will call pkg-config with `--static`, which utilises the `Libs.private` field. Conversely it will not use `--static` when not being built entirely statically, even if there is only a static build of libssh2 available. This will most likely cause the build to fail due to underlinking unless we merge the `Libs` fields. Consider that this is what the Meson build system does when it generates pkg-config files." Follow-up to 1209c16 libssh2#1114 Ref: curl/curl@98e5904 Ref: curl/curl#5373 Closes libssh2#1119
vszakats
force-pushed
the
pc-refix-static-deps
branch
from
b15a180 to
67d222b
Compare
vszakats
changed the title
Libs: for static-only buildsLibs: for static-only builds
This comment was marked as outdated.
This comment was marked as outdated.
vszakats
changed the title
Libs: for static-only buildsLibs: for static-only builds
Quoting the curl commit message (adapted for libssh2): "A project being built entirely statically will call pkg-config with `--static`, which utilises the `Libs.private` field. Conversely it will not use `--static` when not being built entirely statically, even if there is only a static build of libssh2 available. This will most likely cause the build to fail due to underlinking unless we merge the `Libs` fields. Consider that this is what the Meson build system does when it generates pkg-config files." Follow-up to 1209c16 libssh2#1114 Ref: curl/curl@98e5904 Ref: curl/curl#5373 Closes libssh2#1119
vszakats
force-pushed
the
pc-refix-static-deps
branch
from
67d222b to
ada9a97
Compare
Quoting the curl commit message (adapted for libssh2): "A project being built entirely statically will call pkg-config with `--static`, which utilises the `Libs.private` field. Conversely it will not use `--static` when not being built entirely statically, even if there is only a static build of libssh2 available. This will most likely cause the build to fail due to underlinking unless we merge the `Libs` fields. Consider that this is what the Meson build system does when it generates pkg-config files." Follow-up to 1209c16 libssh2#1114 Ref: curl/curl@98e5904 Ref: curl/curl#5373 Closes libssh2#1119
vszakats
force-pushed
the
pc-refix-static-deps
branch
from
ada9a97 to
8dbc258
Compare
vszakats
changed the title
Libs: for static-only builds
vszakats
changed the title
vszakats
changed the title
vszakats
force-pushed
the
pc-refix-static-deps
branch
from
92af986 to
e0b0cb7
Compare
vszakats
changed the title
Adapted for libssh2 from the curl commit message by James Le Cuirot: "A project built entirely statically will call `pkg-config` with `--static`, which utilises the `Libs.private:` field. Conversely it will not use `--static` when not being built entirely statically, even if there is only a static build of libssh2 available. This will most likely cause the build to fail due to underlinking unless we merge the `Libs:` fields. Consider that this is what the Meson build system does when it generates `pkg-config` files." This patch extends the above to `Requires:`, to mirror `Libs:` with `pkg-config` package names. Follow-up to 1209c16 libssh2#1114 Ref: libssh2#1114 (comment) Ref: curl/curl@98e5904 Ref: curl/curl#5373 Closes libssh2#1119
Adapted for libssh2 from the curl commit message by James Le Cuirot: "A project built entirely statically will call `pkg-config` with `--static`, which utilises the `Libs.private:` field. Conversely it will not use `--static` when not being built entirely statically, even if there is only a static build of libssh2 available. This will most likely cause the build to fail due to underlinking unless we merge the `Libs:` fields. Consider that this is what the Meson build system does when it generates `pkg-config` files." This patch extends the above to `Requires:`, to mirror `Libs:` with `pkg-config` package names. Follow-up to 1209c16 libssh2#1114 Ref: libssh2#1114 (comment) Ref: curl/curl@98e5904 Ref: curl/curl#5373 Closes libssh2#1119
1 participant
Adapted for libssh2 from the curl commit message by James Le Cuirot:
"A project built entirely statically will call
pkg-configwith--static, which utilises theLibs.private:field. Conversely it willnot use
--staticwhen not being built entirely statically, even ifthere is only a static build of libssh2 available. This will most
likely cause the build to fail due to underlinking unless we merge the
Libs:fields.Consider that this is what the Meson build system does when it generates
pkg-configfiles."This patch extends the above to
Requires:, to mirrorLibs:withpkg-configpackage names.Follow-up to 1209c16 #1114
Ref: #1114 (comment)
Ref: curl/curl@98e5904
Ref: curl/curl#5373
Closes #1119