fix(llm): allow Codex CLI outside Git repositories#6347
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Codex CLI provider failed when LibreFang was started as a desktop application or daemon outside a Git repository.
The provider check still reported Codex as available because it only verified that the executable and credentials existed. The first real completion then failed with:
The driver also passed the deprecated
--full-autooption, producing a warning on every request.Root cause
LibreFang launched
codex execin the process working directory.Desktop and daemon processes are not guaranteed to start inside a Git repository, while non-interactive Codex execution rejects such directories unless
--skip-git-repo-checkis explicitly supplied.Changes
--skip-git-repo-checktocodex exec.--full-autowith--sandbox workspace-write.Verification
cargo fmt --checkcargo test -p librefang-llm-drivers --lib codex_clicargo clippy -p librefang-llm-drivers --lib -- -D warningslibrefang-desktoprelease package.--skip-git-repo-checkand no longer contains--full-auto.Out of scope
The desktop dashboard currently retries an agent WebSocket connection with an Origin based on its random frontend port, while the API validates it against the separate API listen port. This produces repeated
403 Origin validation failedwarnings. HTTP message fallback still works, and this separate desktop/WebSocket issue is not included in this PR.