fix: complete dashboard i18n coverage#6271
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves dashboard localization coverage for English, Ukrainian, and Chinese.
It adds CI-friendly checks that verify dashboard i18n key coverage, locale parity, CLDR plural forms, dead locale keys, conflicting fallback strings, and unaudited user-facing hardcoded literals. The hardcoded-text coverage now catches rendered JSX expression strings and user-facing object fields/variables, while filtering technical strings such as CSS classes, imports, storage keys, console messages, and keyboard shortcuts.
The PR also routes the hardcoded strings found by those checks through i18n and adds the corresponding translations to
en.json,uk.json, andzh.json.Substantive Changes
en-locale-coverage.test.ts.Verification
npm testnpm run typecheckvitest run src/lib/__tests__/locale-parity.test.ts src/lib/__tests__/en-locale-coverage.test.tsnpm run lintOut Of Scope