ci(macos): skip network-dependent hands registry tests on the macOS lane (#6240)#6247
Merged
Merged
Conversation
…ane (#6240) librefang-hands `registry::tests` clone github.com/librefang/librefang-registry at runtime to populate a test home, then assert >= 15 hands. GitHub-hosted macOS runners resolve crates.io but consistently fail to resolve github.com for this clone ("Could not resolve host: github.com" -> "expected at least 15 hands, got 0"), failing 13 tests deterministically on macOS across every main push while they pass on Linux/Windows where the clone succeeds. The logic under test is platform-independent and fully covered by the Linux + Windows lanes, so exclude just this network-dependent module on the macOS lane via a nextest filter rather than red-flagging every main push. Completes the macOS-red fix begun in #6243 (the i18n half).
github-actions
Bot
added
no-rust-required
houko
enabled auto-merge (squash)
June 20, 2026 01:39
Contributor
Author
|
Pushed one follow-up commit ( Generated by Claude Code |
github-actions
Bot
added
no-rust-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #6240. Completes the macOS-
main-red fix — #6243 fixed the i18n half (test_detect_system_language); this fixes the remaining 13librefang-hands::registry::tests::*failures.Root cause
Those tests call
resolve_home_dir_for_tests(), whichgit clonesgithub.com/librefang/librefang-registryat runtime to populate a test home, then assert>= 15hands. On the GitHub-hosted macOS runner the clone fails:The same runner resolves crates.io fine (it downloads crates), but github.com is consistently unresolvable for this clone — across 6+ consecutive main runs, so it's systematic, not a transient flake. Linux and Windows runners clone successfully and the tests pass there.
Change
Add a nextest filter to the macOS lane only (
ci.yml: test-macos) excludingpackage(librefang-hands) and test(/registry::tests::/). The Linux shards (test-ubuntu,test-unit) and Windows lane keep running the full set, so coverage of this platform-independent logic is unchanged. A comment in the workflow documents why.This is verified on the PR's Linux lanes (which still run the registry tests and must stay green); the macOS filter itself only takes effect on main-push, since macOS does not run on PRs.
Deeper follow-up (out of scope here)
The real smell is that a unit test live-clones an external repo. The proper fix is to bundle the registry as an offline fixture so the tests need no network at all — a larger change to
registry_sync.rsand the registry test harness, in a different area than this one-line CI scoping. Happy to open a tracking issue for it if you want it followed up.Closes #6240.