feat(dashboard): group the Agents list into Core Agents and Hands sections#6205
Merged
Conversation
…tions The Agents page showed every agent in one flat list, with hand-role agents distinguished only by a small per-row badge. Split the already-filtered and -sorted list on the is_hand flag into two titled sections using the pre-seeded agents.core_agents / agents.hands i18n keys; each header renders only when its group is non-empty, so the Show hands toggle keeps its meaning and a single-group view shows no empty banner. Presentational only — no data-layer, query, or backend change; the per-row HAND badge is left untouched to keep the diff minimal. Closes #6189
CHANGELOG.md: split two sentences that were on one line into separate lines (one sentence per line rule). AgentsPage.tsx: trim three-line comment block to one line, keeping only the non-obvious invariant about showHandAgents toggle interaction.
# Conflicts: # .secrets.baseline
houko
enabled auto-merge (squash)
June 19, 2026 04:50
Deploying librefang with
|
| Latest commit: |
78875c2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://601429b3.librefang-7oe.pages.dev |
| Branch Preview URL: | https://feat-6189-agents-hands-group.librefang-7oe.pages.dev |
Deploying librefang-docs with
|
| Latest commit: |
78875c2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cdc4bf91.librefang-docs.pages.dev |
| Branch Preview URL: | https://feat-6189-agents-hands-group.librefang-docs.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6189. The Agents page rendered every agent in a single flat list; hand-role agents were distinguished only by a small per-row
HANDbadge. This groups the list into Core Agents and Hands sections, which reads as more structured.Changes (dashboard-only)
crates/librefang-api/dashboard/src/pages/AgentsPage.tsxfilteredAgentson the existingis_handflag intocoreAgents(!is_hand) andhandAgents(is_hand) — bothuseMemo, derived from the same source so search / state-filter / sort behaviour is unchanged.Show handstoggle keeps its meaning (when off,handAgentsis empty and the Hands header doesn't show) and a single-group view shows no empty banner.agents.core_agents/agents.handsi18n keys (already present in all locales, previously unreferenced).No backend,
api.tstype, query, mutation, or new i18n keys. The auto-select effect and empty-state still key offfilteredAgents, so they are unaffected. The per-rowHANDbadge is left untouched (minimal diff).Verification
No dedicated test is added here: AgentsPage has no render-test harness today (one is introduced by the separate #6187 PR), and a full-page mock would be disproportionate for a presentational regroup. Happy to add one once #6187's harness lands.