fix(ci): pin vendored OpenSSL to Strawberry Perl on the Windows test lane#6171
Merged
Conversation
…lane #6163 added a Windows-gated vendored `openssl-sys` so `webauthn-rs` links, on the assumption the runner's bundled Perl would build it. That assumption only holds outside Git Bash. The `Test / Windows` job runs `cargo nextest` under `shell: bash`, which prepends the MSYS toolchain to `PATH`, so `openssl-src` resolves `perl` to Git Bash's `/usr/share/perl5/core_perl` instead of Strawberry Perl. That Perl cannot configure OpenSSL's `VC-WIN64A` build — its `IPC::Cmd` / `Params::Check` modules fail to compile and `./Configure` aborts, failing both shards with exit code 101. #6163's own CI never caught this because the Windows test lane is main-push-only and does not run on PRs, so the break only surfaced after merge to `main`. Set `OPENSSL_SRC_PERL` (openssl-src's documented Perl override, ahead of `PERL` and the bare `perl` fallback) to the runner's Windows-native `C:/Strawberry/perl/bin/perl.exe` on the test step. NASM is unaffected — the failing Configure args carried no `no-asm`, so the runner's `nasm` was already detected. The release Windows jobs need no change: their `cargo build` step runs under the default `pwsh`, where the system `PATH` resolves `perl` to Strawberry directly. Refs #6161.
github-actions
Bot
added
area/docs
houko
enabled auto-merge (squash)
June 17, 2026 15:04
This was referenced Jun 17, 2026
houko
added a commit
that referenced
this pull request
Jun 23, 2026
…top (#6285) CHANGELOG.md had two `## [Unreleased]` sections: one buried between released version sections (it predates #6281, which then added a duplicate at the top). The release tooling reads only the first [Unreleased] and silently drops the rest, so ~150 stranded entries were never reaching release notes; the duplicate header also tripped the `## [Unreleased]` guard, blocking every CHANGELOG-touching commit (e.g. #5988). Consolidate both blocks into a single [Unreleased] at the top, merging same-named `###` subsections (collapsed 10 redundant subsection headers). Every bullet is preserved verbatim — verified that the multiset of non-header content lines is byte-identical before/after. Drop the two entries already published in released sections: #6272 (in [2026.6.22]) and #6171 (in [2026.6.17]). Co-authored-by: Evan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mainCI is red: bothTest / Windowsshards fail with exit code 101 (run 27696315168). The build aborts compiling vendoredopenssl-sys:Root cause
#6163 added a Windows-gated vendored
openssl-sys(sowebauthn-rslinks) on the assumption that "both Windows runner images already ship the Perl the build requires". That holds only outside Git Bash.The
Test / Windowsjob runscargo nextestundershell: bash, which prepends the MSYS toolchain toPATH.openssl-srcshells out to whicheverperlis first onPATH, so it picks Git Bash's/usr/share/perl5/core_perlinstead of the runner's Strawberry Perl. That Perl cannot configure OpenSSL'sVC-WIN64Atarget — itsIPC::Cmd/Params::Checkmodules fail to compile and./Configureaborts.#6163's own CI never caught this: the Windows test lane is
push/merge_grouponly (ci.yml:888) and does not run on PRs, so the break surfaced only after merge tomain.Fix
Set
OPENSSL_SRC_PERLon the test step to the runner's Windows-native Strawberry Perl. This isopenssl-src's documented Perl override (precedence:OPENSSL_SRC_PERL>PERL> bareperl), added precisely for this case in openssl-src-rs#45.openssl-srcrunswhere nasmand addsno-asmwhen it is missing; the failing./Configureargs carried nono-asm, sonasmwas already detected on the runner.cargo buildstep (release.yml,release-cli.yml) runs under the defaultpwsh, where the systemPATHresolvesperlto Strawberry directly; the bash steps there are packaging/upload only and compile nothing.release-desktop.ymlbuilds viatauri-action, also not under bash.Verification
python3 -c "import yaml; yaml.safe_load(open('.github/workflows/ci.yml'))"— valid YAML.windows-latestimage (C:\strawberry\perl\bin\perl.exe; Windows paths are case-insensitive).Test / Windowslane on this branch's CI run — it ispush-triggered, so it exercises the changed step directly.Refs #6161.