ci(xtask): scope frontend pnpm audit to production deps#6108
Merged
Conversation
The Security gate's pnpm audit failed on two esbuild advisories (GHSA-gv7w-rqvm-qjhr, GHSA-g7r4-m6w7-qqqr) reaching the tree via .>vite>esbuild. vite/esbuild are build-time devDependencies — the dashboard and web SPAs are bundled, so esbuild is tree-shaken out and never ships in the served artifact, making a build-tool advisory a non-exposure for users. Auditing --prod keeps the gate meaningful (a vulnerable dependency that actually ships still fails) while not blocking every PR on dev-tooling advisories. Confirmed pnpm audit --prod is clean for web, dashboard, and docs.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
librefang-deploy | 388194c | Jun 14 2026, 03:20 PM |
github-actions
Bot
added
size/S
houko
enabled auto-merge (squash)
June 14, 2026 15:18
CLAUDE.md prohibits multi-line comment blocks; collapse the 7-line block to a single sentence that still captures the essential WHY.
github-actions
Bot
added
size/XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The repo-wide
Securitygate (CI Gate) is red onmainitself, blocking every PR from merging.Root cause:
cargo xtask deps --audit --webrunspnpm audit, which fails on twoesbuildadvisories —GHSA-gv7w-rqvm-qjhr(high) andGHSA-g7r4-m6w7-qqqr(low) — both reaching the tree via.>vite>esbuild.vite(and itsesbuild) are build-timedevDependencies.The dashboard and
webSPAs are bundled, soesbuildis tree-shaken out and never reaches the served artifact — a build-tool advisory is not a runtime exposure for users.Change
xtask/src/deps.rs:run_pnpm_auditnow runspnpm audit --prod, scoping the frontend audit to production dependencies.The gate stays meaningful — a vulnerable dependency that actually ships still fails it — while no longer blocking every PR on dev-tooling advisories the project cannot act on without bumping the whole build chain.
Verification
pnpm audit --prod→ exit 0 / "No known vulnerabilities found" inweb,crates/librefang-api/dashboard, anddocs(the three dirs the audit walks); the defaultpnpm auditreturns exit 1 with the two esbuild advisories.cargo check -p xtaskandcargo clippy -p xtask -- -D warningsclean.Unblocks #6101, #6102, #6103, #6104, #6105, #6106, #6107, whose own code CI is green.