Skip to content

fix(ci): refresh detect-secrets baseline for migrated Cloudflare account_id#6093

Merged
houko merged 1 commit into
mainfrom
fix/secrets-baseline-cf-account
Jun 11, 2026
Merged

fix(ci): refresh detect-secrets baseline for migrated Cloudflare account_id#6093
houko merged 1 commit into
mainfrom
fix/secrets-baseline-cf-account

Conversation

@houko

@houko houko commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Problem

The secrets (detect-secrets) job has been red on main since fcfbd9e18 / #6092 ("migrate worker config to librefang Cloudflare account").

That PR changed the Cloudflare account_id in web/workers/marketplace-worker/wrangler.toml and web/workers/registry-worker/wrangler.toml from 3ee9bb524a4fb2a9d685ce1f82b52581 to 57449de851e4289a4407a73e66baaac9.
detect-secrets fingerprints that value as a Base64 High Entropy String, so its baseline hash changed — but .secrets.baseline was not regenerated, so the CI re-scan no longer matches the committed baseline:

@@ web/workers/marketplace-worker/wrangler.toml
-        "hashed_secret": "952f171c2975b07d40de194f1745c3dad8f9a3ce",
+        "hashed_secret": "abfc409c5d78e0b185b919c28eb7824214fec52c",
@@ web/workers/registry-worker/wrangler.toml
-        "hashed_secret": "952f171c2975b07d40de194f1745c3dad8f9a3ce",
+        "hashed_secret": "abfc409c5d78e0b185b919c28eb7824214fec52c",

A Cloudflare account ID is a public account identifier, not a credential, so this is a false-positive class entry — the fix is to update the baseline, not to redact anything.

Change

Update only the two wrangler.toml baseline entries to the rescanned hash abfc409c….

The old hash 952f171c… also appears on a third entry — crates/librefang-runtime/src/plugin_manager/registry.rs (an embedded registry pubkey).
That value was not changed by #6092 and CI's fresh scan still produces 952f171c… for it, so that entry is deliberately left untouched (a blind global replace would have corrupted it).

Verification

  • git diff is exactly the two intended lines (2 insertions(+), 2 deletions(-)); registry.rs entry still carries 952f171c….
  • .secrets.baseline re-parses as valid JSON.
  • The new hashes match the exact values CI's re-scan reported in the failing run.
  • detect-secrets is not installed locally, so the surgical edit reproduces CI's expected baseline (the strip-and-diff check ignores generated_at / version / line_number, so leaving generated_at as-is is fine).

…unt_id

PR #6092 migrated the worker config to the librefang Cloudflare account, changing `account_id` in `web/workers/marketplace-worker/wrangler.toml` and `web/workers/registry-worker/wrangler.toml` from `3ee9bb52…` to `57449de8…`.
detect-secrets flags that value as a Base64 High Entropy String, so its baseline hash changed, but `.secrets.baseline` still carried the old hash and the secret-scan job on main failed against the committed baseline.

Update only the two wrangler.toml entries to the rescanned hash (`abfc409c…`).
The unrelated `plugin_manager/registry.rs` embedded-pubkey entry that coincidentally shares the old hash is left untouched.
@github-actions github-actions Bot added the size/XS < 10 lines changed label Jun 11, 2026
@houko
houko merged commit ca5c61a into main Jun 11, 2026
29 checks passed
@houko
houko deleted the fix/secrets-baseline-cf-account branch June 11, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS < 10 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant