fix(ci): refresh detect-secrets baseline for migrated Cloudflare account_id#6093
Merged
Conversation
…unt_id PR #6092 migrated the worker config to the librefang Cloudflare account, changing `account_id` in `web/workers/marketplace-worker/wrangler.toml` and `web/workers/registry-worker/wrangler.toml` from `3ee9bb52…` to `57449de8…`. detect-secrets flags that value as a Base64 High Entropy String, so its baseline hash changed, but `.secrets.baseline` still carried the old hash and the secret-scan job on main failed against the committed baseline. Update only the two wrangler.toml entries to the rescanned hash (`abfc409c…`). The unrelated `plugin_manager/registry.rs` embedded-pubkey entry that coincidentally shares the old hash is left untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
secrets(detect-secrets) job has been red onmainsincefcfbd9e18/ #6092 ("migrate worker config to librefang Cloudflare account").That PR changed the Cloudflare
account_idinweb/workers/marketplace-worker/wrangler.tomlandweb/workers/registry-worker/wrangler.tomlfrom3ee9bb524a4fb2a9d685ce1f82b52581to57449de851e4289a4407a73e66baaac9.detect-secrets fingerprints that value as a
Base64 High Entropy String, so its baseline hash changed — but.secrets.baselinewas not regenerated, so the CI re-scan no longer matches the committed baseline:A Cloudflare account ID is a public account identifier, not a credential, so this is a false-positive class entry — the fix is to update the baseline, not to redact anything.
Change
Update only the two
wrangler.tomlbaseline entries to the rescanned hashabfc409c….The old hash
952f171c…also appears on a third entry —crates/librefang-runtime/src/plugin_manager/registry.rs(an embedded registry pubkey).That value was not changed by #6092 and CI's fresh scan still produces
952f171c…for it, so that entry is deliberately left untouched (a blind global replace would have corrupted it).Verification
git diffis exactly the two intended lines (2 insertions(+), 2 deletions(-));registry.rsentry still carries952f171c…..secrets.baselinere-parses as valid JSON.detect-secretsis not installed locally, so the surgical edit reproduces CI's expected baseline (the strip-and-diff check ignoresgenerated_at/version/line_number, so leavinggenerated_atas-is is fine).