fix(api/skills): repair test build after #5455 (write_service_account_env removed)#5460
Merged
Conversation
…count_env #5455 (webhook→sidecar) folded write_service_account_env into the generic write_secret_env (same newline-rejection contract) but left this test calling the removed name, breaking the librefang-api test build (E0425). Point the test at write_secret_env and rename it to match.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#5455 (webhook → sidecar) landed on
mainwith a broken test build: it foldedwrite_service_account_envinto the genericwrite_secret_env(same newline-rejection contract) but leftroutes/skills.rs's test calling the removed name —error[E0425]: cannot find function write_service_account_envin thelibrefang-apilib test. This re-brokemainimmediately after #5456 recovered it.Fix
Point the test at
write_secret_envand rename itwrite_secret_env_value_with_newline_is_rejected. Same assertions (newline →InvalidInput, message mentions "newline", no file written) —write_secret_env(skills.rs:5431) enforces exactly that.Verified:
cargo check --workspace --all-targetsclean; the test passes.Note
mainkeeps breaking because the channel-sidecar PRs are merging while their build/test checks are still pending — branch protection isn't gating on them. Worth requiring theTest/ coverage checks before merge so this stops recurring.