fix(kernel): unblock main — pass force=false in compact gate test (#5210/#5213 collision)#5245
Merged
Merged
Conversation
… test PR #5213 added a third bool parameter `force` to compact_agent_session_with_id (forced /compact, async spawn). PR #5210 added test_compact_gate_passes_when_tokens_above_threshold_but_messages_below which calls the method with two arguments — the call site was not updated when #5213 landed on top of #5210, and main has been red since that merge (E0061: this method takes 3 arguments but 2 arguments were supplied at crates/librefang-kernel/src/kernel/tests.rs:8972). Pass `false` — this test pins the token-trigger gate (#5210), not the user-forced bypass path (#5213). The force=true case is covered separately.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
main has been red since #5213 merged on top of #5210:
test_compact_gate_passes_when_tokens_above_threshold_but_messages_belowatcrates/librefang-kernel/src/kernel/tests.rs:8972, callingcompact_agent_session_with_id(agent_id, Some(session_id))— two args.force: boolparameter (forced /compact, async spawn). feat(kernel,api,channels,dashboard): forced /compact with async spawn, ack+event, summary banner #5213's branch was forked before fix(kernel): honor token-trigger in inner compaction gate #5210 landed, so when feat(kernel,api,channels,dashboard): forced /compact with async spawn, ack+event, summary banner #5213 was rebased the new test was not updated. Both PRs' own CI was green at merge time; the collision only surfaces onmainafter the second merge.Result: every CI lane red since
ae410968:Fix
Pass
force = falseat that call site. The test pins the token-trigger gate (#5210), not the user-forced bypass path (#5213);falseis the correct value, with a 3-line comment explaining the choice.Verification
cargo check -p librefang-kernel --profile=test --libclean (was the failing target).Notes
No follow-up needed; the force=true case is already covered by #5213's own tests. Surfaced while triaging CI red on #5241.