Skip to content

fix(kernel): unblock main — pass force=false in compact gate test (#5210/#5213 collision)#5245

Merged
houko merged 1 commit into
mainfrom
fix/compact-test-missing-force-arg
May 18, 2026
Merged

fix(kernel): unblock main — pass force=false in compact gate test (#5210/#5213 collision)#5245
houko merged 1 commit into
mainfrom
fix/compact-test-missing-force-arg

Conversation

@houko

@houko houko commented May 18, 2026

Copy link
Copy Markdown
Contributor

Problem

main has been red since #5213 merged on top of #5210:

Result: every CI lane red since ae410968:

error[E0061]: this method takes 3 arguments but 2 arguments were supplied
   --> crates/librefang-kernel/src/kernel/tests.rs:8972:10
8972 |         .compact_agent_session_with_id(agent_id, Some(session_id))
     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------------------- argument #3 of type `bool` is missing

Fix

Pass force = false at that call site. The test pins the token-trigger gate (#5210), not the user-forced bypass path (#5213); false is the correct value, with a 3-line comment explaining the choice.

Verification

  • cargo check -p librefang-kernel --profile=test --lib clean (was the failing target).
  • Surrounding test logic untouched — only the missing argument is added.

Notes

No follow-up needed; the force=true case is already covered by #5213's own tests. Surfaced while triaging CI red on #5241.

… test

PR #5213 added a third bool parameter `force` to
compact_agent_session_with_id (forced /compact, async spawn). PR #5210
added test_compact_gate_passes_when_tokens_above_threshold_but_messages_below
which calls the method with two arguments — the call site was not
updated when #5213 landed on top of #5210, and main has been red since
that merge (E0061: this method takes 3 arguments but 2 arguments were
supplied at crates/librefang-kernel/src/kernel/tests.rs:8972).

Pass `false` — this test pins the token-trigger gate (#5210), not the
user-forced bypass path (#5213). The force=true case is covered
separately.
@houko
houko merged commit 8827b48 into main May 18, 2026
10 checks passed
@houko
houko deleted the fix/compact-test-missing-force-arg branch May 18, 2026 17:35
@github-actions github-actions Bot added area/kernel Core kernel (scheduling, RBAC, workflows) size/XS < 10 lines changed labels May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/kernel Core kernel (scheduling, RBAC, workflows) size/XS < 10 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant