test(api): regenerate kernel_config_schema golden fixture#4002
Merged
Conversation
Several recently-merged PRs added new fields to KernelConfig without regenerating the golden fixture: - app_secret_env (Messenger HMAC) from #3942 - security_token_env (Teams HMAC) from #3942 - public_base_url (mobile pairing) from #3344 The drift caused kernel_config_schema_matches_golden_fixture to fail on every open PR's CI (Test/Ubuntu/Windows/macOS), blocking ~30 in-flight fixes from merging even though their own changes were unrelated to the config schema. Regenerated via: cargo test -p librefang-api --test config_schema_golden \ -- --ignored regenerate_golden --nocapture 29 lines added, no removals — purely additive new optional fields.
github-actions
Bot
added
no-rust-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recently-merged PRs added new fields to
KernelConfigwithout regenerating the golden fixture:app_secret_env(Messenger HMAC, fix(channels): mandatory webhook HMAC verification + SSRF guard #3942)security_token_env(Teams HMAC, fix(channels): mandatory webhook HMAC verification + SSRF guard #3942)public_base_url(mobile pairing, Mobile daemon connection wizard with manual entry + QR pairing #3344/feat(mobile): daemon connection wizard with QR pairing (#3344) #3916)The drift caused
kernel_config_schema_matches_golden_fixtureto fail on every open PR's CI (Test / Ubuntu, Windows, macOS), blocking ~30 in-flight fixes from merging even though their own changes were unrelated to the config schema.Regenerated via
Test plan
cargo test -p librefang-api --test config_schema_goldenpasses locally