fix: add kill_on_drop(true) to prevent orphan subprocess accumulation#3883
Merged
Conversation
Without kill_on_drop(true), dropping a Child handle does not terminate the child process. Tool runner and MCP stdio processes would accumulate as zombies/orphans after agent session teardown.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kill_on_drop(true)totool_runner.rsmain tool execution path (tool_runner exec spawns subprocess without kill_on_drop — orphans on outer timeout #3471)kill_on_drop(true)totool_runner.rsffmpeg OGG transcoding subprocesskill_on_drop(true)to MCP stdio child process inlibrefang-runtime-mcp/src/lib.rs(MCP stdio child process not killed on drop — leaks subprocess on hot reload #3800)Without
kill_on_drop(true), dropping aChildhandle (e.g., on timeout or session cancellation) does not terminate the child process. Tool runner and MCP server processes would accumulate as orphans after agent session teardown.Fixes
Test plan