feat(dashboard/audit): move filters into right-docked drawer#3254
Merged
Conversation
The collapsible filter card sat at the top of the page above the results, sticky and ~80–250px tall depending on expand state. Above the fold meant fewer rows visible; below the fold the operator had to scroll back up to refilter. Move the form into a right-docked panel-right Modal that opens on the existing 'Filters' button. Inline strip kept above results carries: - 'Filters' trigger with the same active-count badge - Drilled-in active filter chips (still removable in-place) - Clear-all shortcut Drawer body restructured for its narrower width: single-column field stack instead of the 3-col grid, sticky Reset / Apply footer at the bottom so commits stay reachable on short viewports. Quick-range presets close the drawer on click (apply-and-go), Apply also closes the drawer (the chip strip already shows what's active). panel-right (not drawer-right) because the form is modal — tweaks aren't live, the operator commits via Apply, dim backdrop signals that and Esc / click-outside dismiss.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
github-actions
Bot
added
ready-for-review
2 tasks
houko
added a commit
that referenced
this pull request
Apr 27, 2026
…tons (#3289) The 1h / 24h / today / 7d / 30d quick-pick buttons in the audit filter drawer call `applyDatePreset(p)` (AuditPage.tsx:786) but the function itself was never defined — so `pnpm typecheck` errored on `Cannot find name 'applyDatePreset'` and the buttons crashed at runtime when clicked. Add the function inline next to `onClearAll`. Behavior matches the spec already documented at line 297: snap `draft.from` to the preset's `since()` value, clear `draft.to`, and push the change into `active` so the audit query refetches without the operator having to press Apply. Closes the typecheck regression introduced when filters were moved into the right-docked drawer (#3254).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The audit page's filter card sat at the top above the results: sticky, ~80–250px tall depending on expand state. Above the fold meant fewer rows visible; below the fold the operator had to scroll back up to refilter. Move the form into a right-docked panel-right Modal that opens on the existing Filters button.
The slim inline strip kept above results carries:
Drawer body restructured for its narrower width
Why panel-right instead of drawer-right
panel-right(dim backdrop, click-outside closes) — the form is modal: tweaks aren't live, the operator commits via Apply. The dim backdrop signals that and gives Esc / click-outside as the standard dismiss paths.drawer-rightmakes more sense for inspector views where the underlying list stays interactive; the audit filter form is the opposite shape.Test plan
/dashboard/audit→ filter strip renders as a single inline row (no big card).