Skip to content

ci: install libdbus-1-dev for OpenAPI Drift job#3186

Merged
houko merged 1 commit into
mainfrom
ci/install-libdbus-for-openapi-drift
Apr 25, 2026
Merged

ci: install libdbus-1-dev for OpenAPI Drift job#3186
houko merged 1 commit into
mainfrom
ci/install-libdbus-for-openapi-drift

Conversation

@houko

@houko houko commented Apr 25, 2026

Copy link
Copy Markdown
Contributor

Summary

The OpenAPI Drift CI job is currently failing on every PR that touches Rust code (and on main itself since #3178 merged).

Root cause: PR #3178 added a keyring dep for OS keyring vault wiring. On Linux, keyring pulls in secret-servicedbuslibdbus-sys, which needs dbus-1 dev headers + pkg-config to compile. Other Rust jobs (Test, Quality, Build) get these transitively via libwebkit2gtk-4.1-dev, but the openapi-drift job installs no system deps — so cargo xtask codegen --openapi errors out:

error: failed to run custom build command for `libdbus-sys v0.2.7`
pkg-config exited with status code 1
> pkg-config --libs --cflags dbus-1 'dbus-1 >= 1.6'

This adds an explicit apt-get install libdbus-1-dev libsecret-1-dev pkg-config step before the codegen step. Tiny + targeted — only the openapi-drift job is changed.

Test plan

The keyring crate (added in #3178 for OS keyring vault wiring) pulls
in libdbus-sys via secret-service on Linux, which needs dbus-1 dev
headers + pkg-config to compile. Other Rust jobs already get these
transitively via libwebkit2gtk-4.1-dev, but the openapi-drift job
installs no system deps and was failing on every Rust-touching PR.

Adds an explicit apt-get install step before cargo xtask codegen.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actions github-actions Bot added ready-for-review PR is ready for maintainer review area/ci CI/CD and build tooling no-rust-required This task does not require Rust knowledge size/XS < 10 lines changed and removed ready-for-review PR is ready for maintainer review labels Apr 25, 2026
@houko
houko merged commit a2f35d0 into main Apr 25, 2026
22 checks passed
@houko
houko deleted the ci/install-libdbus-for-openapi-drift branch April 25, 2026 17:24
@houko houko mentioned this pull request Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci CI/CD and build tooling no-rust-required This task does not require Rust knowledge size/XS < 10 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant