ci: install libdbus-1-dev for OpenAPI Drift job#3186
Merged
Conversation
The keyring crate (added in #3178 for OS keyring vault wiring) pulls in libdbus-sys via secret-service on Linux, which needs dbus-1 dev headers + pkg-config to compile. Other Rust jobs already get these transitively via libwebkit2gtk-4.1-dev, but the openapi-drift job installs no system deps and was failing on every Rust-touching PR. Adds an explicit apt-get install step before cargo xtask codegen.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
OpenAPI DriftCI job is currently failing on every PR that touches Rust code (and onmainitself since #3178 merged).Root cause: PR #3178 added a
keyringdep for OS keyring vault wiring. On Linux,keyringpulls insecret-service→dbus→libdbus-sys, which needsdbus-1dev headers +pkg-configto compile. Other Rust jobs (Test,Quality,Build) get these transitively vialibwebkit2gtk-4.1-dev, but theopenapi-driftjob installs no system deps — socargo xtask codegen --openapierrors out:This adds an explicit
apt-get install libdbus-1-dev libsecret-1-dev pkg-configstep before the codegen step. Tiny + targeted — only the openapi-drift job is changed.Test plan