fix(dashboard): stop drawer scroll chaining into the page#3169
Merged
Conversation
When the agent / provider / skill / hand drawer scrolled past its top or bottom edge, the wheel event chained up to the underlying page — visible because the drawer variant deliberately leaves the page interactive (no dim backdrop, pointer-events-none on the container). Add overscroll-contain to Modal's children scroll wrapper so the gesture stops at the dialog boundary. The change applies to centred modals too, which fixes a pre-existing papercut: a long modal sitting over a long page would, on bottoming out, start scrolling the page underneath even though the backdrop visually suggested the page was locked.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug from #3166: scrolling inside an agent / provider / skill drawer past its top or bottom edge propagated the wheel gesture to the underlying page. The drawer variant intentionally leaves the page interactive (no dim backdrop,
pointer-events-noneon the container), so scroll chaining was visible — the page slid under the drawer mid-scroll, jarring.Fix
One Tailwind class on
Modal's scroll wrapper:overscroll-behavior: containtells the browser to stop the wheel event at this element's boundary instead of propagating to ancestors. Standard CSS, well-supported.The change applies to centred modals too, which silently fixes a pre-existing papercut: a long modal over a long page used to scroll the page once the modal bottomed out, even though the dim backdrop suggested the page was locked.
Test plan