fix(observability): drop ingester/compactor from Tempo config#3067
Merged
Conversation
The Tempo image's config parser rejects these sections with:
failed parsing config: yaml: unmarshal errors:
line 18: field ingester not found in type app.Config
line 21: field compactor not found in type app.Config
Caught when testing #3064's stack end-to-end: librefang-tempo restart-
looped and never served :3200 until both sections were removed. Those
fields were nice-to-haves (block duration / retention tuning); their
built-in defaults are fine for a local dev stack. A comment points at
the Tempo docs for anyone who wants to re-add them with the correct
schema for their image version.
github-actions
Bot
added
ready-for-review
github-actions
Bot
removed
the
ready-for-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tiny fix caught when running the stack from #3064 end-to-end. The Tempo
latestimage refuses to start with:librefang-temporestart-loops;:3200never comes up; Grafana's Tempodatasource shows "No data" because there's no Tempo to query.
The
ingester:/compactor:sections I added were nice-to-haves(block flush cadence + 24h retention). Their built-in defaults are fine
for a local dev stack. A comment points at the Tempo docs for anyone
who wants to re-add them with the correct schema for their image
version.
Test plan
docker restart librefang-tempowith the new config — containerstays
Up,curl http://localhost:3200/api/search ...returnsvalid JSON instead of connection-refused.
trace visible (confirmed locally after fix(telemetry): move env_filter to fmt layer so OTel sees INFO spans #3065 also merges).