style: apply cargo fmt to runtime drivers#2380
Merged
Merged
Conversation
…ry test The dispatch loop never accrued three errors because health_order() reroutes to the healthy secondary after the first failure. Seed the counters directly so the test exercises what it claims to.
houko
disabled auto-merge
April 13, 2026 13:48
houko
added a commit
that referenced
this pull request
Jun 24, 2026
… instead of dropping them PatchAgentConfigRequest declares api_key_env and base_url and the OpenAPI schema for /config advertises both, but patch_agent_config never read them — only the sibling patch_hand_agent_runtime_config did. A client that switched a non-hand agent to a custom provider plus its credential env var / base URL in one PATCH /config call got 200 while the two fields were silently discarded, leaving the agent on stale credentials/URL (the #2380 class of failure). /config now applies them via update_model_provider_config after set_agent_model (which clears stale overrides on a provider change). Tri-state per field: a non-empty value sets it, an empty/whitespace value clears it, an absent field is left unchanged (merged against the current value so sending one field does not wipe the other). No OpenAPI change — the schema already advertised these fields; this makes behavior match the contract. Adds integration tests for the apply path and the empty-string-clears / absent-preserves semantics.
houko
added a commit
that referenced
this pull request
Jun 24, 2026
… instead of dropping them PatchAgentConfigRequest declares api_key_env and base_url and the OpenAPI schema for /config advertises both, but patch_agent_config never read them — only the sibling patch_hand_agent_runtime_config did. A client that switched a non-hand agent to a custom provider plus its credential env var / base URL in one PATCH /config call got 200 while the two fields were silently discarded, leaving the agent on stale credentials/URL (the #2380 class of failure). /config now applies them via update_model_provider_config after set_agent_model (which clears stale overrides on a provider change). Tri-state per field: a non-empty value sets it, an empty/whitespace value clears it, an absent field is left unchanged (merged against the current value so sending one field does not wipe the other). No OpenAPI change — the schema already advertised these fields; this makes behavior match the contract. Adds integration tests for the apply path and the empty-string-clears / absent-preserves semantics.
houko
added a commit
that referenced
this pull request
Jun 24, 2026
… instead of dropping them PatchAgentConfigRequest declares api_key_env and base_url and the OpenAPI schema for /config advertises both, but patch_agent_config never read them — only the sibling patch_hand_agent_runtime_config did. A client that switched a non-hand agent to a custom provider plus its credential env var / base URL in one PATCH /config call got 200 while the two fields were silently discarded, leaving the agent on stale credentials/URL (the #2380 class of failure). /config now applies them via update_model_provider_config after set_agent_model (which clears stale overrides on a provider change). Tri-state per field: a non-empty value sets it, an empty/whitespace value clears it, an absent field is left unchanged (merged against the current value so sending one field does not wipe the other). No OpenAPI change — the schema already advertised these fields; this makes behavior match the contract. Adds integration tests for the apply path and the empty-string-clears / absent-preserves semantics.
houko
added a commit
that referenced
this pull request
Jun 24, 2026
… instead of dropping them PatchAgentConfigRequest declares api_key_env and base_url and the OpenAPI schema for /config advertises both, but patch_agent_config never read them — only the sibling patch_hand_agent_runtime_config did. A client that switched a non-hand agent to a custom provider plus its credential env var / base URL in one PATCH /config call got 200 while the two fields were silently discarded, leaving the agent on stale credentials/URL (the #2380 class of failure). /config now applies them via update_model_provider_config after set_agent_model (which clears stale overrides on a provider change). Tri-state per field: a non-empty value sets it, an empty/whitespace value clears it, an absent field is left unchanged (merged against the current value so sending one field does not wipe the other). No OpenAPI change — the schema already advertised these fields; this makes behavior match the contract. Adds integration tests for the apply path and the empty-string-clears / absent-preserves semantics.
houko
added a commit
that referenced
this pull request
Jun 24, 2026
… instead of dropping them (#6303) PatchAgentConfigRequest declares api_key_env and base_url and the OpenAPI schema for /config advertises both, but patch_agent_config never read them — only the sibling patch_hand_agent_runtime_config did. A client that switched a non-hand agent to a custom provider plus its credential env var / base URL in one PATCH /config call got 200 while the two fields were silently discarded, leaving the agent on stale credentials/URL (the #2380 class of failure). /config now applies them via update_model_provider_config after set_agent_model (which clears stale overrides on a provider change). Tri-state per field: a non-empty value sets it, an empty/whitespace value clears it, an absent field is left unchanged (merged against the current value so sending one field does not wipe the other). No OpenAPI change — the schema already advertised these fields; this makes behavior match the contract. Adds integration tests for the apply path and the empty-string-clears / absent-preserves semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Quality job failure on main (run 24345544883).
cargo fmt --checkflagged two spots inqwen_code.rsand one infallback.rs; this appliescargo fmt --allverbatim — no logic changes.