Skip to content

style: apply cargo fmt to runtime drivers#2380

Merged
houko merged 2 commits into
mainfrom
fix/cargo-fmt-runtime-drivers
Apr 13, 2026
Merged

style: apply cargo fmt to runtime drivers#2380
houko merged 2 commits into
mainfrom
fix/cargo-fmt-runtime-drivers

Conversation

@houko

@houko houko commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Fixes the Quality job failure on main (run 24345544883). cargo fmt --check flagged two spots in qwen_code.rs and one in fallback.rs; this applies cargo fmt --all verbatim — no logic changes.

@github-actions github-actions Bot added the area/runtime Agent loop, LLM drivers, WASM sandbox label Apr 13, 2026
@houko
houko enabled auto-merge (squash) April 13, 2026 13:44
…ry test

The dispatch loop never accrued three errors because health_order()
reroutes to the healthy secondary after the first failure. Seed the
counters directly so the test exercises what it claims to.
@houko
houko disabled auto-merge April 13, 2026 13:48
@houko
houko merged commit 02e6782 into main Apr 13, 2026
3 checks passed
@houko
houko deleted the fix/cargo-fmt-runtime-drivers branch April 13, 2026 13:48
houko added a commit that referenced this pull request Jun 24, 2026
… instead of dropping them

PatchAgentConfigRequest declares api_key_env and base_url and the OpenAPI schema for /config advertises both, but patch_agent_config never read them — only the sibling patch_hand_agent_runtime_config did.
A client that switched a non-hand agent to a custom provider plus its credential env var / base URL in one PATCH /config call got 200 while the two fields were silently discarded, leaving the agent on stale credentials/URL (the #2380 class of failure).

/config now applies them via update_model_provider_config after set_agent_model (which clears stale overrides on a provider change). Tri-state per field: a non-empty value sets it, an empty/whitespace value clears it, an absent field is left unchanged (merged against the current value so sending one field does not wipe the other).

No OpenAPI change — the schema already advertised these fields; this makes behavior match the contract. Adds integration tests for the apply path and the empty-string-clears / absent-preserves semantics.
houko added a commit that referenced this pull request Jun 24, 2026
… instead of dropping them

PatchAgentConfigRequest declares api_key_env and base_url and the OpenAPI schema for /config advertises both, but patch_agent_config never read them — only the sibling patch_hand_agent_runtime_config did.
A client that switched a non-hand agent to a custom provider plus its credential env var / base URL in one PATCH /config call got 200 while the two fields were silently discarded, leaving the agent on stale credentials/URL (the #2380 class of failure).

/config now applies them via update_model_provider_config after set_agent_model (which clears stale overrides on a provider change). Tri-state per field: a non-empty value sets it, an empty/whitespace value clears it, an absent field is left unchanged (merged against the current value so sending one field does not wipe the other).

No OpenAPI change — the schema already advertised these fields; this makes behavior match the contract. Adds integration tests for the apply path and the empty-string-clears / absent-preserves semantics.
houko added a commit that referenced this pull request Jun 24, 2026
… instead of dropping them

PatchAgentConfigRequest declares api_key_env and base_url and the OpenAPI schema for /config advertises both, but patch_agent_config never read them — only the sibling patch_hand_agent_runtime_config did.
A client that switched a non-hand agent to a custom provider plus its credential env var / base URL in one PATCH /config call got 200 while the two fields were silently discarded, leaving the agent on stale credentials/URL (the #2380 class of failure).

/config now applies them via update_model_provider_config after set_agent_model (which clears stale overrides on a provider change). Tri-state per field: a non-empty value sets it, an empty/whitespace value clears it, an absent field is left unchanged (merged against the current value so sending one field does not wipe the other).

No OpenAPI change — the schema already advertised these fields; this makes behavior match the contract. Adds integration tests for the apply path and the empty-string-clears / absent-preserves semantics.
houko added a commit that referenced this pull request Jun 24, 2026
… instead of dropping them

PatchAgentConfigRequest declares api_key_env and base_url and the OpenAPI schema for /config advertises both, but patch_agent_config never read them — only the sibling patch_hand_agent_runtime_config did.
A client that switched a non-hand agent to a custom provider plus its credential env var / base URL in one PATCH /config call got 200 while the two fields were silently discarded, leaving the agent on stale credentials/URL (the #2380 class of failure).

/config now applies them via update_model_provider_config after set_agent_model (which clears stale overrides on a provider change). Tri-state per field: a non-empty value sets it, an empty/whitespace value clears it, an absent field is left unchanged (merged against the current value so sending one field does not wipe the other).

No OpenAPI change — the schema already advertised these fields; this makes behavior match the contract. Adds integration tests for the apply path and the empty-string-clears / absent-preserves semantics.
houko added a commit that referenced this pull request Jun 24, 2026
… instead of dropping them (#6303)

PatchAgentConfigRequest declares api_key_env and base_url and the OpenAPI schema for /config advertises both, but patch_agent_config never read them — only the sibling patch_hand_agent_runtime_config did.
A client that switched a non-hand agent to a custom provider plus its credential env var / base URL in one PATCH /config call got 200 while the two fields were silently discarded, leaving the agent on stale credentials/URL (the #2380 class of failure).

/config now applies them via update_model_provider_config after set_agent_model (which clears stale overrides on a provider change). Tri-state per field: a non-empty value sets it, an empty/whitespace value clears it, an absent field is left unchanged (merged against the current value so sending one field does not wipe the other).

No OpenAPI change — the schema already advertised these fields; this makes behavior match the contract. Adds integration tests for the apply path and the empty-string-clears / absent-preserves semantics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/runtime Agent loop, LLM drivers, WASM sandbox

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant