fix: skip approval gate for full shell exec policy#23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shell_execwhen the effective agentexec_policy.modeisFullProblem
LibreFang already deserializes per-agent
exec_policyoverrides correctly, butexecute_tool()was still running the approval gate before it knew whether the effective policy wasFull.That meant agents configured with
exec_policy = "allow"could still be blocked by the human approval flow before the shell-exec policy was considered.Verification
cargo fmt --all --checkcargo check -p librefang-runtimecargo test -p librefang-runtime test_shell_exec_full_policy_skips_approval_gatecargo test -p librefang-runtime test_shell_exec_non_full_policy_still_requires_approvalCloses #22
Upstream reference: RightNow-AI/openfang#222