fix: handle Slack app_mention events#17
Merged
Merged
Conversation
houko
force-pushed
the
fix/slack-app-mention
branch
from
March 13, 2026 03:48
7b0d1c0 to
1cefe23
Compare
…vents Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
houko
added a commit
that referenced
this pull request
Apr 17, 2026
**CI (#17, #28, #55)**: move `corepack enable` to run AFTER `actions/setup-node` in all four workflows (deploy-web, deploy-docs, lighthouse, test-web). Corepack shims are installed into whichever Node lives on PATH at the time; running it first means setup-node later switches to a different Node install that lacks the shims, causing intermittent `pnpm: command not found` failures. **Web (#34)**: registry detail page now tries both MCP manifest layouts — flat `mcp/<id>.toml` (legacy, still the majority) and directory-backed `mcp/<id>/MCP.toml` (new, multi-file packages) — matching what `web/scripts/fetch-registry.ts` already accepts. The resolved path (whichever candidate returns 200) is what the "View on GitHub" and commit-history lookups use, so those links always point at the file the user is actually viewing. Extracted `pathCandidatesFor` and `fetchFirstAvailable` into `web/src/lib/registry-raw.ts` so the list page's hover-prefetch and the detail page's real fetch share one cache entry and one source of truth for path layout. Dropped the redundant `fileNameFor` field from `CATEGORY_META` — it duplicated the same knowledge.
houko
added a commit
that referenced
this pull request
Apr 18, 2026
… pnpm Codex comments #17, #28, #55 asked us to move `corepack enable` after `actions/setup-node`, arguing that corepack's shims are bound to the pre-setup-node Node install. In practice the opposite is true: the `cache: pnpm` option on setup-node runs `pnpm --version` to compute the cache key during setup, so pnpm MUST be on PATH before that step. Putting corepack after setup-node fails every run with `Unable to locate executable file: pnpm` — which is what we saw on deploy-web, deploy-docs, lighthouse, and test-web after the previous commit. Modern setup-node (v6 + Node ≥22, which bundles corepack) preserves corepack shims across the Node swap, so one `corepack enable` up front is both necessary and sufficient. Restore the original ordering in all four workflows and leave a comment explaining why the Codex-suggested ordering doesn't work here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app_mentionevents in the Socket Mode adaptermetadata["was_mentioned"] = trueforapp_mentionmessagesWhy
The current Slack adapter only parses
messageevents, so pure @mentions can be ignored when Slack emitsapp_mention.Upstream reference
Testing
cargo fmt --all --checkcargo check -p librefang-channelscargo test -p librefang-channels test_parse_slack_app_mention_sets_was_mentionedCloses #16