Skip to content

fix: handle Slack app_mention events#17

Merged
houko merged 3 commits into
mainfrom
fix/slack-app-mention
Mar 13, 2026
Merged

fix: handle Slack app_mention events#17
houko merged 3 commits into
mainfrom
fix/slack-app-mention

Conversation

@houko

@houko houko commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • accept Slack app_mention events in the Socket Mode adapter
  • set metadata["was_mentioned"] = true for app_mention messages
  • add a targeted parser test for the mention metadata path

Why

The current Slack adapter only parses message events, so pure @mentions can be ignored when Slack emits app_mention.

Upstream reference

Testing

  • cargo fmt --all --check
  • cargo check -p librefang-channels
  • cargo test -p librefang-channels test_parse_slack_app_mention_sets_was_mentioned

Closes #16

@houko
houko force-pushed the fix/slack-app-mention branch from 7b0d1c0 to 1cefe23 Compare March 13, 2026 03:48
@houko
houko merged commit a264c8a into main Mar 13, 2026
8 checks passed
@houko
houko deleted the fix/slack-app-mention branch March 13, 2026 04:34
houko added a commit that referenced this pull request Apr 17, 2026
**CI (#17, #28, #55)**: move `corepack enable` to run AFTER
`actions/setup-node` in all four workflows (deploy-web, deploy-docs,
lighthouse, test-web). Corepack shims are installed into whichever
Node lives on PATH at the time; running it first means setup-node
later switches to a different Node install that lacks the shims,
causing intermittent `pnpm: command not found` failures.

**Web (#34)**: registry detail page now tries both MCP manifest
layouts — flat `mcp/<id>.toml` (legacy, still the majority) and
directory-backed `mcp/<id>/MCP.toml` (new, multi-file packages) —
matching what `web/scripts/fetch-registry.ts` already accepts. The
resolved path (whichever candidate returns 200) is what the
"View on GitHub" and commit-history lookups use, so those links
always point at the file the user is actually viewing.

Extracted `pathCandidatesFor` and `fetchFirstAvailable` into
`web/src/lib/registry-raw.ts` so the list page's hover-prefetch
and the detail page's real fetch share one cache entry and one
source of truth for path layout. Dropped the redundant
`fileNameFor` field from `CATEGORY_META` — it duplicated the
same knowledge.
houko added a commit that referenced this pull request Apr 18, 2026
… pnpm

Codex comments #17, #28, #55 asked us to move `corepack enable` after
`actions/setup-node`, arguing that corepack's shims are bound to the
pre-setup-node Node install. In practice the opposite is true: the
`cache: pnpm` option on setup-node runs `pnpm --version` to compute
the cache key during setup, so pnpm MUST be on PATH before that step.
Putting corepack after setup-node fails every run with
`Unable to locate executable file: pnpm` — which is what we saw on
deploy-web, deploy-docs, lighthouse, and test-web after the previous
commit.

Modern setup-node (v6 + Node ≥22, which bundles corepack) preserves
corepack shims across the Node swap, so one `corepack enable` up
front is both necessary and sufficient. Restore the original ordering
in all four workflows and leave a comment explaining why the
Codex-suggested ordering doesn't work here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle Slack app_mention events in the Socket Mode adapter

1 participant