Repository navigation
docs: add missing libSQL row to test-database table - #1637
Merged
Merged
Conversation
Member
|
thanks and welcome |
Contributor
Author
|
Thanks for the warm welcome and for merging my PR! I'm a self-taught developer, so it was nice to contribute to the project. I haven't actually used LibreDB Studio yet. I came across the documentation issue, saw that I could help, and decided to fix it. Glad I could contribute, and thanks again! |
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1265.
Two changes to the local test-database table in
docs/providers/README.md, both from the issue:libSQL row added.
| libSQL | \libsql` | localhost | 18080 | none | none | none | — |, placed after the Redis row and before Couchbase, matching the order the paragraph above the table counts the engine containers in. Port18080is bold like OpenSearch's9201, because it is not the engine's usual port:database-compose.ymlmaps the container's8080to18080so it does not collide with Trino. No user, password or token, no TLS, no profile — the compose service carries noprofiles:key anddocs/providers/libsql.md` describes the auth-free local mode.*none*in theProfilecolumn replaced with the em dash the PostgreSQL row uses. The issue named the Prometheus, Apache Kafka, etcd and Neo4j rows (lines 284-287 of the pinned commit). Since thenmainhas gained more rows carrying the same wrong placeholder — InfluxDB 1.x, InfluxDB 2.x, InfluxDB 3 (SQL), Oxia, Milvus and Qdrant — so all ten are fixed here, which is what the "Done when" criterion ("every row that needs no profile shows the same placeholder") asks for.*none*is defined under the table as "leave the field empty", which cannot apply to a column that is not a connection field.Only
docs/providers/README.mdchanges. The User, Password and Database columns keep their*none*placeholders — those are connection fields and the placeholder is correct there.Verification
git diff --stat: one file, 11 insertions, 10 deletions.database-compose.yml(servicelibsql, port mapping18080:8080, noprofiles:key) anddocs/providers/libsql.md(auth-free local mode, no TLS) rather than assumed.Lint, Typecheck and BuildandUnit & Integration Testsare left to run on the PR.