This repository was archived by the owner on Jun 26, 2023. It is now read-only.
Merged
Conversation
Replaces the node `EventEmitter` with the pure-js `EventTarget` class.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 10, 2022
## [@libp2p/interfaces-v1.3.1](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interfaces-v1.3.0...@libp2p/interfaces-v1.3.1) (2022-02-10) ### Bug Fixes * remove node event emitters ([#161](#161)) ([221fb6a](221fb6a))
|
🎉 This PR is included in version @libp2p/interfaces-v1.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 10, 2022
## [@libp2p/logger-v1.0.2](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/logger-v1.0.1...@libp2p/logger-v1.0.2) (2022-02-10) ### Bug Fixes * remove node event emitters ([#161](#161)) ([221fb6a](221fb6a))
|
🎉 This PR is included in version @libp2p/logger-v1.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 10, 2022
## [@libp2p/peer-id-v1.1.1](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/peer-id-v1.1.0...@libp2p/peer-id-v1.1.1) (2022-02-10) ### Bug Fixes * remove node event emitters ([#161](#161)) ([221fb6a](221fb6a))
|
🎉 This PR is included in version @libp2p/peer-id-v1.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 10, 2022
## [@libp2p/tracked-map-v1.0.1](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/tracked-map-v1.0.0...@libp2p/tracked-map-v1.0.1) (2022-02-10) ### Bug Fixes * remove node event emitters ([#161](#161)) ([221fb6a](221fb6a))
|
🎉 This PR is included in version @libp2p/tracked-map-v1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 10, 2022
## [@libp2p/topology-v1.1.1](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/topology-v1.1.0...@libp2p/topology-v1.1.1) (2022-02-10) ### Bug Fixes * remove node event emitters ([#161](#161)) ([221fb6a](221fb6a))
|
🎉 This PR is included in version @libp2p/topology-v1.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 10, 2022
## [@libp2p/peer-id-factory-v1.0.4](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/peer-id-factory-v1.0.3...@libp2p/peer-id-factory-v1.0.4) (2022-02-10) ### Bug Fixes * remove node event emitters ([#161](#161)) ([221fb6a](221fb6a))
|
🎉 This PR is included in version @libp2p/peer-id-factory-v1.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 10, 2022
## [@libp2p/pubsub-v1.2.1](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/pubsub-v1.2.0...@libp2p/pubsub-v1.2.1) (2022-02-10) ### Bug Fixes * remove node event emitters ([#161](#161)) ([221fb6a](221fb6a))
|
🎉 This PR is included in version @libp2p/pubsub-v1.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 10, 2022
## [@libp2p/interface-compliance-tests-v1.1.1](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-compliance-tests-v1.1.0...@libp2p/interface-compliance-tests-v1.1.1) (2022-02-10) ### Bug Fixes * remove node event emitters ([#161](#161)) ([221fb6a](221fb6a))
|
🎉 This PR is included in version @libp2p/interface-compliance-tests-v1.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 10, 2022
## [@libp2p/connection-v1.1.1](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/connection-v1.1.0...@libp2p/connection-v1.1.1) (2022-02-10) ### Bug Fixes * remove node event emitters ([#161](#161)) ([221fb6a](221fb6a))
|
🎉 This PR is included in version @libp2p/connection-v1.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 10, 2022
## [@libp2p/peer-record-v1.0.1](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/peer-record-v1.0.0...@libp2p/peer-record-v1.0.1) (2022-02-10) ### Bug Fixes * remove node event emitters ([#161](#161)) ([221fb6a](221fb6a))
|
🎉 This PR is included in version @libp2p/peer-record-v1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 10, 2022
## [@libp2p/peer-store-v1.0.1](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/peer-store-v1.0.0...@libp2p/peer-store-v1.0.1) (2022-02-10) ### Bug Fixes * remove node event emitters ([#161](#161)) ([221fb6a](221fb6a))
|
🎉 This PR is included in version @libp2p/peer-store-v1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the node
EventEmitterwith the pure-jsEventTargetclass.All events are now instances of Event.
For typing CustomEvent can be used which gives us a typed
.detailfield.Tediously
EventTargetitself doesn't support typed events (yet?) and node.js doesn't supportCustomEventglobally so bit of trickery was required but hopefully this can be removed in future: