Merged
Conversation
pietbrauer
requested changes
May 29, 2017
Member
pietbrauer
left a comment
pietbrauer
left a comment
There was a problem hiding this comment.
Thanks a lot! Looks good at a first glance. Could you add some simple tests for this? You could copy one of the existing ones, just add more than 1 file to it.
Contributor
Author
|
Sure, I just thought the test suite is ignored on this project. |
Member
|
I look at it. We "just" have one failing test on macOS which is consistent 😆. iOS is a different story. |
Contributor
Author
|
Yeah, would be great if all the tests worked... But I do too see the value in testing. I'll probably get around to the tests this weekend. |
Member
|
Yeah, many people have spent many hours trying to fix the tests. Thanks a lot! No pressure from my side 😅 |
Contributor
Author
|
#599 has a green iOS build, but it is already 5 months old. |
Member
Member
Contributor
Author
|
@pietbrauer Thanks for fixing the build! 👍 |
Contributor
Author
|
I added a small test. |
pietbrauer
approved these changes
Jun 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the user to do something like
git add -A