Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support index.skipHash true config #6738

Merged
merged 9 commits into from
Feb 17, 2024
Merged

Support index.skipHash true config #6738

merged 9 commits into from
Feb 17, 2024

Conversation

parnic
Copy link
Contributor

@parnic parnic commented Feb 16, 2024

When this is set, the checksum at the end of the index is zero.

Fixes #6531

When this is set, the checksum at the end of the index is zero.

Fixes #6531
Copy link
Member

@ethomson ethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix - I would request a few minor formatting suggestions. 🙏

parnic and others added 4 commits February 17, 2024 08:13
Co-authored-by: Edward Thomson <ethomson@edwardthomson.com>
Co-authored-by: Edward Thomson <ethomson@edwardthomson.com>
Co-authored-by: Edward Thomson <ethomson@edwardthomson.com>
@parnic
Copy link
Contributor Author

parnic commented Feb 17, 2024

Thanks for the fix - I would request a few minor formatting suggestions. 🙏

Sure thing - all done.

@ethomson
Copy link
Member

I think that we need to git_index_free in the test - I pushed up a quick change to your branch to make sure that's the problem.

@ethomson
Copy link
Member

Cool - thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git 2.40.0 index.skipHash incompatible with libgit2
2 participants