GIT_RAND_GETENTROPY: do not include sys/random.h #6736
Conversation
CMakeLists.txt is looking for unistd.h (where the getentropy function is present for at least Linux and OpenBSD). It isn't necessary to include sys/random.h (which is Linux only). It unbreak the build on OpenBSD.
|
For reference, the CMakeLists.txt#L87 detection. From getentropy(3) man page, it should be at least glibc 2.25. |
|
The test failing seems unrelated at first look: the job compiled fine (so the include removal was accepted by the compiler), and it failed during the test seems to failed due to |
Indeed - it looks like we need to update our valgrind suppression settings — OpenSSL has some cases where it (intentionally) doesn't initialize memory and valgrind treats that as tainted, and thus our data is treated as tainted as a result as well. |
CMakeLists.txt is looking for
unistd.h(where thegetentropyfunction is present for at least Linux and OpenBSD).It isn't necessary to include
sys/random.h(which is Linux only).It unbreak the build on OpenBSD.