Skip to content

Potential loose/packed ref race when deleting packed refs #5003

Closed

Description

@ethomson

As @peff noted in #4981:

refdb_fs_backend__delete_tail doesn't have this bug, but I think creates its own race. It deletes the loose ref first, before touching packed-refs. During the moment between those two steps, a reader would see the packed-refs value as the authoritative one, but it's garbage at that point (it was some previous value that the ref had, but it could be very old, and possibly not even a reachable object). This was fixed in upstream Git by git/git@dc39e09.

Activity

  1. pks-t commented on Sep 27, 2019

    @pks-t
    Member

    Both #4984 and #5106 have been merged, so the race shouldn't exist anymore. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions