Repository navigation
Renaming the current branch doesn't cause a message to be written to the HEAD reflog #4292
Description
In the case that the currently checked-out branch is renamed, Git core has logic to write to HEAD's reflog instead of only the ref-specific reflog (https://github.com/git/git/blob/e0aaa1b6532cfce93d87af9bc813fb2e7a7ce9d7/refs/files-backend.c#L2156-L2186). libgit2, however, only writes to the ref-specific reflog.
Reproduction steps
- Rename the currently checked-out branch via
git_reference_rename(for example, check outdevelopmentand rename it todevelop).
Expected behavior
- The reflog for the new name of the branch should be written to (for example,
.git/logs/refs/heads/developshould containbranch: renamed...). - The reflog for
HEADshould be written to (for example,.git/logs/HEADshould containbranch: renamed....
Actual behavior
- The reflog for the new name of the branch is written to (for example,
.git/logs/refs/heads/developshould containbranch: renamed...). - The reflog for
HEADis not written to (for example,.git/logs/HEADshould containbranch: renamed....
Version of libgit2 (release number or SHA1)
v0.25.1
Operating system(s) tested
macOS
Activity
tests: test case for libgit2#4292
tests: test case for libgit2#4292
tests: test case for libgit2#4292
tiennou commentedon Jul 17, 2017
Just a heads up, I think you want
git_branch_move(eg.git branch -m develop) instead ofgit_reference_rename(eg.git update-ref development refs/heads/develop). I haven't checked what the reflog show in that case though, so YMMV.jgrosso commentedon Jul 17, 2017
@tiennou Thanks! IIRC,
git_branch_movecallsgit_reference_renameunder the hood; while I'm not 100% sure of that, my testing did showgit_branch_moveto have the same problem with the reflog.tests: test case for libgit2#4292
tests: test case for libgit2#4292
tiennou commentedon Jul 17, 2017
Just checked, and there's still only the reflog line added by
git_repository_set_headin theHEADreflog. Hopefully, I'll have a preliminary PR soon-ish.(Sorry for the spam, I rebased the test and pushed the wrong one 😟)
tests: test case for libgit2#4292