Skip to content

improve gitignore template fix libgdx/libgdx#4560#4580

Merged
Tom-Ski merged 1 commit into
libgdx:masterfrom
mgsx-dev:fix/gitignore
Feb 5, 2017
Merged

improve gitignore template fix libgdx/libgdx#4560#4580
Tom-Ski merged 1 commit into
libgdx:masterfrom
mgsx-dev:fix/gitignore

Conversation

@mgsx-dev

Copy link
Copy Markdown
Contributor

as discussed in #4560, here is the fix (maybe not the final fix).

I'm not really confident with these modifications because I'm not using all OS/IDE/Targets. I'm using eclipse on linux and mostly target desktop and android so I think this fix should be validated by more contributors.

Has you can see, what I've done so far is :

  • add leading slashes and full path to avoid unwanted ignore.
  • removed some duplicates : for instance html/war/WEB-INF/deploy/ is useless with /html/war
  • removed some IMO useless : tmp/
  • move local.properties to gradle section

Note that I could use single wildcard instead of path for every sub project (for instance /*/dist/) but it could conflicts with some project specific folder structure.

@Tom-Ski : I don't really understand why you want to keep just one big file instead of dispatching some parts in related sub projects. It would be cleaner way for many reasons :

  • make gitignore files more readable.
  • avoid useless ignore when not targeting all platforms.
  • easily manage sub folder renaming / moving.

Thanks to point me in the right direction in order to improve these changes.

@Tom-Ski

Tom-Ski commented Feb 5, 2017

Copy link
Copy Markdown
Member

Mostly for the benefit of people new to git. Just like with gradle we have all the dependencies declared in the root build.gradle file as that makes it easier for people new to gradle to see project definitions, compare them and add/remove what they need without having to forage around in an environment they aren't used to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants