Skip to content

Add useful method#4093

Merged
MobiDevelop merged 3 commits into
libgdx:masterfrom
VinceAngel:quote_replacement
Jan 17, 2017
Merged

Add useful method#4093
MobiDevelop merged 3 commits into
libgdx:masterfrom
VinceAngel:quote_replacement

Conversation

@VinceAngel

Copy link
Copy Markdown
Contributor

Useful method to manage quote replacement in paths

@jsjolund

Copy link
Copy Markdown
Contributor

Maybe you could provide a use case for the method? Also, your code is not correctly formatted:
https://github.com/libgdx/libgdx/wiki/Contributing#eclipse-formatter

@VinceAngel

Copy link
Copy Markdown
Contributor Author

This method is missing since it's in the jdk but not in gwt backend.

@MobiDevelop

Copy link
Copy Markdown
Member

Looks ok to me, one small optimization you could do is initialize the StringBuilder with a capacity at least the size of the string being passed in.

@VinceAngel

Copy link
Copy Markdown
Contributor Author

Found this, I forget it for a while... still ready to be merged :)

@MobiDevelop MobiDevelop merged commit ab05f39 into libgdx:master Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants