Fix erroneous semi colon in FFI_EXTRA_CIF_FIELDS on some platforms#968
Merged
Conversation
Signed-off-by: Stewart X Addison <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seen on riscv64 when building with
clangusing the-Werror-semi -Werrorparameters as per nodejs/unofficial-builds#235The
FFI_EXTRA_CIF_FIELDSdefinition on some platforms has an extra trailing semicolon meaning that when it is referenced inlibffi/include/ffi.h.in
Line 254 in c5abbda
I've only tested with this on riscv but since I saw what seems to be the same on two other platforms I've also corrected it there.
The failure is reproducible with any source file that includes
ffi.hon RISC-V:clang-20 -c hello.cc -Werror-semi -Werror