Conversation
For the benefit and technical details of static trampoline, see libffi#624. As a new architecture, let's be "safer" from the start. The change survived libffi testsuite on loongarch64-linux-gnu.
xry111
left a comment
xry111
left a comment
There was a problem hiding this comment.
@xen0n Please review.
@Panxuefeng-loongson Please test if this change broke your downstream works.
| .size ffi_call_asm, .-ffi_call_asm | ||
|
|
||
|
|
||
| /* ffi_closure_asm. Expects address of the passed-in ffi_closure in t1. |
There was a problem hiding this comment.
Note: this is a document typo, which cost me half an hour to debug some "bus error".
Sorry for not replying to you in time. Currently, all I can use are loongnix machines. So, there is no way to verify on the new world machine. If all libffi tests pass, it will not have a very big impact on applications such as jna. Thanks |
|
Sorry for the late reply, I briefly looked at the code and it seemed great. I hoped to integrate this into Gentoo for wide testing but |
4 participants
For the benefit and technical details of static trampoline, see
#624. As a new architecture, let's
be "safer" from the start.
The change survived libffi testsuite on loongarch64-linux-gnu.