Conversation
1. ported sysv.S to win64_armasm.S for armasm64 assembler
2. added msvc_build folder for visual studio solution
3. updated README.md for the same
4. MSVC solution created with the changes, and below test suites are tested
with test script written in python.
libffi.bhaible
libffi.call
5. Basic functionality of above test suites are getting passed
Signed-off-by: ossdev07 <[email protected]>
| $env:HOST="arm-w32-cygwin" | ||
| $env:MSVCC="/cygdrive/c/projects/libffi/msvcc.sh -marm" | ||
| $env:SRC_ARCHITECTURE="arm" | ||
| } ElseIf ($env:Platform -Match "arm64") { |
There was a problem hiding this comment.
For "arm64", Appveyor matches "arm" first, and makes it to use the ARM32 toolchain instead of the ARM64 toolchain.
You can see this behavior in https://ci.appveyor.com/project/atgreen/libffi/builds/24605359/job/pagcp8q8htpxynna?fullLog=true.
You might want to consider to move arm64 above of arm.
There was a problem hiding this comment.
Thanks! Good catch. I have submitted a fix.
|
Closing and reopening to trigger appveyor tests to run again. |
|
Appveyor tests passed this time. A travis test failed but it looks like test infrastructure to me rather than code change. |
|
If the travis build failure is not blocking please merge this. |
Hello, |
4 participants
Based on #486 by @ossdev07
ported sysv.S to win64_armasm.S for armasm64 assembler
added msvc_build folder for visual studio solution
updated README.md for the same
MSVC solution created with the changes, and below test suites are tested
with test script written in python.
libffi.bhaible
libffi.call
Basic functionality of above test suites are getting passed
Added:
6. Python 3.8 uses the cygwin build to create libffi-7.dll for use with Python, so I added changes to support the cygwin build of libffi on Windows.
7. Added a appveyor build for arm64 which should succeed.
8. Ifdef'd call to ffi_data_to_code_pointer() because malloc and dmalloc don't mix.
9. All Python ctypes tests pass with these changes.
@atgreen