libffi: added ARM64 support for Windows#483
Closed
ossdev07 wants to merge 1 commit intolibffi:masterfrom
Closed
Conversation
1. ported sysv.S to win64_armasm.S for armasm64 assembler
2. added msvc_build folder for visual studio solution
3. updated README.md for the same
4. MSVC solution created with the changes, and below test suites are tested
with test script written in python.
libffi.bhaible
libffi.call
5. Basic functionality of above test suites are getting passed
Signed-off-by: ossdev07 <[email protected]>
Contributor
Author
This was referenced Apr 16, 2019
atgreen
reviewed
Apr 22, 2019
atgreen
reviewed
Apr 22, 2019
atgreen
reviewed
Apr 22, 2019
| void *x0; | ||
|
|
||
| asm volatile ( | ||
| "adr %0, 0f\n" |
Member
There was a problem hiding this comment.
It's hard to tell what's going on here. Did you make whitespace changes (tabs/spaces)? Please try to remove the whitespace changes so we can see what's really going on.
atgreen
requested changes
Apr 22, 2019
Member
atgreen
left a comment
atgreen
left a comment
There was a problem hiding this comment.
Thanks for your patch! Please have a look at the comments.
AG
Contributor
|
I enabled the current Windows port build environment (MSVC on Cygwin) for this port. |
Contributor
Author
Thanks for the review , i have applied all the comments |
Contributor
Contributor
Author
|
closing this PR because #486 is merged .. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ossdev07 [email protected]